DOC-9723: Couchbase++ Client Settings admonitions #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While parts of Couchbase++ use in Node.js are still in flux, we do need to mention this.
osfameron
requested review from
RichardSmedley,
brett19,
maria-robobug and
raycardillo
maria-robobug
approved these changes
Mar 10, 2022
Contributor
maria-robobug
left a comment
maria-robobug
left a comment
There was a problem hiding this comment.
👍 LGTM, just some minor suggestions.
RichardSmedley
approved these changes
Mar 10, 2022
Contributor
RichardSmedley
left a comment
RichardSmedley
left a comment
There was a problem hiding this comment.
It's not a great situation to be documenting atm,
but +1 to @maria-robobug 's suggestions,
then 
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While parts of Couchbase++ use in Node.js are still in flux, we do need to
mention this.