Skip to content

is this helpful task completed #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarantha-k merged 3 commits into from
May 18, 2020
Merged

is this helpful task completed #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5473d83
is this helpful task completed
May 13, 2020
b28c41a
removing ES lint error for is this page helpful task
May 13, 2020
7006264
Fix the issues for "is helpful task" section..
May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/css/doc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
.doc h4,
.doc h5,
.doc h6 {
font-weight: var(--weight-medium);
font-weight: var(--weight-semibold);
letter-spacing: -0.025rem;
line-height: 1.2;
margin: 1.5rem 0 -0.25rem;
Expand All @@ -27,7 +27,7 @@
}

.doc h2 {
font-size: 1.875rem;
font-size: 2rem;
margin: 2.25rem 0 2.5rem;
max-width: fit-content;
/* NOTE used to restrict width of key line */
Expand Down
19 changes: 15 additions & 4 deletions src/css/is-this-helpful.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
margin: 15px 0;
}

.is-this-helpful-box .btn-row .helpfull-btn {
.is-this-helpful-box .btn-row .helpful-btn {
font-size: 0.875rem;
line-height: 1.125rem;
color: var(--color-brand-gray4);
}

.is-this-helpful-box .btn-row .helpfull-btn:hover,
.is-this-helpful-box .btn-row .helpfull-btn.active {
.is-this-helpful-box .btn-row .helpful-btn:hover,
.is-this-helpful-box .btn-row .helpful-btn.active {
color: var(--color-brand-blue);
text-decoration: none;
}
Expand All @@ -44,7 +44,7 @@
border-radius: 5px;
border: 1px solid var(--color-brand-gray5);
resize: vertical;
font-size: 1rem;
font-size: 0.875rem;
color: var(--color-brand-gray4);
font-family: "Source Sans Pro", sans-serif;
}
Expand Down Expand Up @@ -98,6 +98,17 @@
color: var(--color-brand-blue);
}

.toc .any-feedback a {
font-size: 0.875rem;
line-height: 20px;
text-decoration: none;
color: var(--color-brand-blue);
font-weight: var(--weight-normal);
margin-bottom: 15px;
display: inline-block;
width: 100%;
}

.is-this-helpful-box .action-btn-row .info-btn {
font-size: 0.75rem;
line-height: 0.75rem;
Expand Down
6 changes: 6 additions & 0 deletions src/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,9 @@ main p {
align-items: flex-start;
}
}

@media screen and (max-width: 767px) {
.main {
padding-bottom: 2rem;
}
}
37 changes: 21 additions & 16 deletions src/js/06-page-rating.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,53 @@
;(function () {
;
(function () {
'use strict'

var dialogBox = document.getElementById('dialogBox')
var helpYesBtn = document.getElementById('yesBtn')
var helpNoBtn = document.getElementById('noBtn')
var skipBtnMsg = document.getElementById('skipBtnMsg')
var feedBackFormBox = document.getElementById('additionalFeedbackBox')
var leaveAddtinalBox = document.getElementById('leaveAddtinalBox')
var skipLeaveBtn = document.getElementById('skipLeaveBtn')
// var leaveAddtinalBox = document.getElementById('leaveAddtinalBox')
// var skipLeaveBtn = document.getElementById('skipLeaveBtn')
var feedBackMsg = document.querySelector('.feed-back-msg')
var submitBtn = document.querySelector('.submit-btn')
var leaveYesBtn = document.querySelector('.yes-btn')
// var leaveYesBtn = document.querySelector('.yes-btn')
var feedbackInfoBtn = document.querySelector('.info-btn')
var feedbackModal = document.querySelector('.feedback-modal')
var closeModalPopup = document.querySelector('.close-popup')
var anyFeedbackBtn = document.querySelector('.any-feedback-btn')
// for config
var yesBtnData = helpYesBtn.dataset
var noBtnData = helpNoBtn.dataset

helpYesBtn.addEventListener('click', function (e) {
dialogBox.style.display = 'block'
// dialogBox.style.display = 'block'
this.classList.add('active')
helpNoBtn.classList.remove('active')
console.log(yesBtnData, 16)
})
helpNoBtn.addEventListener('click', function (e) {
dialogBox.style.display = 'block'
// dialogBox.style.display = 'block'
this.classList.add('active')
helpYesBtn.classList.remove('active')
console.log(noBtnData, 27)
})

skipBtnMsg.addEventListener('click', function (e) {
feedBackFormBox.style.display = 'none'
leaveAddtinalBox.style.display = 'block'
})
skipLeaveBtn.addEventListener('click', function (e) {
leaveAddtinalBox.style.display = 'none'
anyFeedbackBtn.addEventListener('click', function (e) {
e.preventDefault()
dialogBox.style.display = 'block'
feedBackFormBox.style.display = 'block'
this.classList.add('active')
})

skipBtnMsg.addEventListener('click', function (e) {
dialogBox.style.display = 'none'
feedBackMsg.value = ''
})
// skipLeaveBtn.addEventListener('click', function (e) {
// leaveAddtinalBox.style.display = 'none'
// feedBackFormBox.style.display = 'block'
// })

feedBackMsg.addEventListener('keyup', function (e) {
var textareaValue = this.value

Expand All @@ -49,9 +57,6 @@
submitBtn.classList.add('disabled')
}
})
leaveYesBtn.addEventListener('click', function (e) {
leaveAddtinalBox.style.display = 'none'
})
feedbackInfoBtn.addEventListener('click', function (e) {
feedbackModal.classList.add('show')
})
Expand Down
21 changes: 12 additions & 9 deletions src/partials/toc.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,40 @@
<div class="sidebar-box">
<div class="toc-menu"></div>
<div class="is-this-helpful-box">
<h4> Is this page helpful ?</h4>
<h4> Is this page helpful?</h4>
<div class="btn-row">
<a href="#" class="like-btn helpfull-btn" id="yesBtn" data-page-rating="like" >
<a href="#" class="like-btn helpful-btn" id="yesBtn" data-page-rating="like" >
<i class="far fa-thumbs-up"></i>
Yes

</a>
<a href="#" class="dislike-btn helpfull-btn" id="noBtn" data-page-rating="dislike"> <i class="far fa-thumbs-down"></i> No</a>
<a href="#" class="dislike-btn helpful-btn" id="noBtn" data-page-rating="dislike"> <i class="far fa-thumbs-down"></i> No</a>
</div>
<div class="any-feedback">
<a href="#" class="btn any-feedback-btn">Leave Additional Feedback? </a>
</div>
<div class="dialog-box" id="dialogBox">
<form>
<div class="form-group " id="additionalFeedbackBox">
<div class="form-group " id="additionalFeedbackBox">
<textarea class="input-control feed-back-msg" rows="8" placeholder="Any Additonal Feedback?"></textarea>

<div class="action-btn-row ">
<a href="#" class="skip-btn" id="skipBtnMsg">Skip</a>
<button class="submit-btn btn blue-btn disabled" > Submit </button>
<a href="#" class="info-btn"><i class="fas fa-info-circle"></i></a>
</div>


</div>

<div class="leave-addtional-box" id="leaveAddtinalBox">
{{!-- <div class="leave-addtional-box" id="leaveAddtinalBox">
<div class="text-msg"> <p>Leave Additional Feedback?</p> </div>
<div class="action-btn-row leave-feedback-btn-row">
<a href="#" class="skip-btn" id="skipLeaveBtn">Skip</a>
<button class="yes-btn btn blue-btn"> Yes </button>

</div>
</div>
</div> --}}
</form>

</div>
Expand Down