View source url style #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarantha-k
approved these changes
Jun 25, 2020
Contributor
|
@mojavelinux The deploy preview looks good to me. Could you review and let Rakesh know if any changes are required? Thx |
mojavelinux
approved these changes
Jun 25, 2020
Contributor
mojavelinux
left a comment
mojavelinux
left a comment
There was a problem hiding this comment.
Yep, that works.
@amarantha-k One question I had for you was about the terminology. Before we commit to it on both ends, I want to make sure we have it right. Does data-source-url make sense to you? Or should it be data-view-source-url or something else?
Contributor
|
Yes, data-source-url makes sense. |
Contributor
|
I noticed that this isn't using the Font Awesome icon from Font Awesome. Though since it's added dynamically, we'd need a way to preregister icons that aren't found in the HTML. That is something we could do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amarantha-k ,
I implemented a view-source icon on code blocks.