Sandbox site validation UI fixes #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarantha-k
approved these changes
Jun 26, 2020
Contributor
amarantha-k
left a comment
amarantha-k
left a comment
There was a problem hiding this comment.
looks like it may work. I'll merge so we can test it on the sandbox site.
Contributor
|
@rakeshAlgo update for #20 did not work. |
Contributor
Author
|
Let me check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amarantha-k ,
I have fixed point 26 and 20 points.
In points 20, I added a class to hide nav menu, If we have nav element is empty. But not able to test locally. So I'm not sure it's working yet or not.