Skip to content

Conversation

@rakeshAlgo
Copy link
Contributor

Hi @amarantha-k ,
I have fixed video thumbnail & small lagging issues on the top level landing page.

@rakeshAlgo rakeshAlgo requested a review from amarantha-k June 29, 2020 06:49
return el
}

// hide left nav on top level landing page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be necessary to use JavaScript to hide the nav on the top level landing page. You can simply remove it from the template (and adjust the CSS if necessary).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakeshAlgo please update this PR with the (new) landing page template for top-level page when it's available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amarantha-k ,
Please merge this PR, in the next PR I"ll remove hide nav script for top-level page.
And will create a new landing page without the navigation for the top-level landing page.

@mojavelinux
Copy link
Contributor

@amarantha-k The deploy previews are working again.

Copy link
Contributor

@amarantha-k amarantha-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to pick up UI updates. The update to remove script in landing pages will be submitted in the next PR.

@amarantha-k amarantha-k merged commit 3ca1775 into master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants