-
Notifications
You must be signed in to change notification settings - Fork 21
video thumbnail & Top level page lagging UI fixes #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| return el | ||
| } | ||
|
|
||
| // hide left nav on top level landing page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be necessary to use JavaScript to hide the nav on the top level landing page. You can simply remove it from the template (and adjust the CSS if necessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rakeshAlgo please update this PR with the (new) landing page template for top-level page when it's available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amarantha-k ,
Please merge this PR, in the next PR I"ll remove hide nav script for top-level page.
And will create a new landing page without the navigation for the top-level landing page.
36663b2 to
99d3c10
Compare
|
@amarantha-k The deploy previews are working again. |
…andbox into ui-bug-fixes
…into ui-bug-fixes
amarantha-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to pick up UI updates. The update to remove script in landing pages will be submitted in the next PR.
Hi @amarantha-k ,
I have fixed video thumbnail & small lagging issues on the top level landing page.