Skip to content

Conversation

@amarantha-k
Copy link
Contributor

No description provided.

@amarantha-k amarantha-k requested a review from rakeshAlgo June 29, 2020 14:37
@amarantha-k
Copy link
Contributor Author

@rakeshAlgo In the deploy preview, i'm unable to select the checkboxes for role = "Mobile Developer" and language = "Node.js". Could you take a look please?

@rakeshAlgo
Copy link
Contributor

Okay @amarantha-k , Let me check.

@rakeshAlgo
Copy link
Contributor

rakeshAlgo commented Jun 29, 2020

Amarantha, Please make the same name input id and label for .

<li>
                            <input type="checkbox" id="mobile" class="check-mark" name="role" value="mobile">
                            <label for="mobile">Mobile Developer</label>
                        </li>

image

on deploy preview, this is different for the mobile developer and node js.
So make those things with the same name.

@amarantha-k amarantha-k requested a review from mojavelinux June 29, 2020 15:05
@amarantha-k
Copy link
Contributor Author

amarantha-k commented Jun 29, 2020

@rakeshAlgo Thanks for catching that! Please take a look now

@amarantha-k amarantha-k removed the request for review from mojavelinux June 29, 2020 15:16
@amarantha-k
Copy link
Contributor Author

Verified in deploy preview that it works.

@amarantha-k amarantha-k merged commit 747fc9c into master Jun 29, 2020
@amarantha-k amarantha-k deleted the filter-options branch June 29, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants