Skip to content

Conversation

@rakeshAlgo
Copy link
Contributor

No description provided.

@rakeshAlgo rakeshAlgo requested a review from amarantha-k July 9, 2020 12:47
@amarantha-k
Copy link
Contributor

@rakeshAlgo Could you resolve the merge conflicts please?

@rakeshAlgo
Copy link
Contributor Author

Hi @amarantha-k ,
I resolved the conflict, Please check.

@amarantha-k
Copy link
Contributor

@mojavelinux The deploy preview fails with an error in netlify.toml. Could you take a look please?

@amarantha-k amarantha-k requested a review from mojavelinux July 20, 2020 17:39
@mojavelinux
Copy link
Contributor

@amarantha-k The failure is due to a CSS syntax error. The fact that it throws an exception instead of reporting the error is something I need to address (the linter API changed and I need to backport the fix from the default UI).

@mojavelinux
Copy link
Contributor

If you rebase against master, the crash will be fixed. You will then be able to see the source of the CSS error.

@rakeshAlgo
Copy link
Contributor Author

Hi @amarantha-k ,
I rebase this branch against master. And after that, I fixed CSS Error and resolved the conflict. Please look into this.

@amarantha-k amarantha-k merged commit a48cfbd into master Jul 24, 2020
@amarantha-k amarantha-k deleted the fix-spacing-issues branch September 25, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants