Skip to content

Conversation

@mojavelinux
Copy link
Contributor

No description provided.

Copy link
Contributor

@amarantha-k amarantha-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mojavelinux
Copy link
Contributor Author

Excellent! Since the production site does not currently use the 404 page, this is safe to merge. I'll take care of that. The production site will only start using the 404 once we reconfigure the nginx server in production (on the ec2 instance in AWS). But once I merge, you'll be able to see it in action on the staging site.

@mojavelinux mojavelinux merged commit 2f3b936 into couchbase:master Dec 17, 2020
@mojavelinux mojavelinux deleted the 404-with-router branch December 17, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants