(misc) Random seed generater does not need to be alive as static thread_local#33
(misc) Random seed generater does not need to be alive as static thread_local#33simnalamburt wants to merge 1 commit intocouchbase:masterfrom
Conversation
|
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement. Keep in mind that the emails we are seeing on the commits are: Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed. ::SDKBOT/PR:no_cla |
|
I signed the CLA. Please proceed the code review process. |
|
@simnalamburt, please submit your patch through gerrit. Github is just a mirror, we don't work with pull requests. |
The 'std::random_device rd' will be used only once at the initialization phase of 'gen' variable. It'll only consume the RAM even if it stays alive as static thread_local variable. Reference: https://issues.couchbase.com/browse/CCBC-963 Change-Id: I8120b8e62a6ee54b46590daa155e2f93867c0d1f
|
Your changes (commit: 0903049) have been pushed to the Couchbase Review Site: ::SDKBOT/PR:created |
|
Fixed in 8d7babf |
3 participants
The
std::random_device rdwill be used only once at the initialization phase ofgenvariable. It'll only consume the RAM even if it stays alive as a static thread_local variable.Reference