Sprint 3 Tuesday Release #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SearchbarAssembly is now a child of SearchbarDrawer. Button in corner opens drawer revealing SearchBar GraphViewAssembly calls SearchBarDrawer
…nto sprint3-local
Searchbar results now scrolls. (renders results in sets of 40) Added Dummy function that returns the ID of a course clicked from search results
Creates a new graph object with list of nodes and edges. Shows all nodes and edges leading up to a course
filter works on the current selected node. it will give back a list of nodes
should give back a list of nodes and edges
Connnected filtergraph function to graphview. Can now search a course and see all its prereqs on the graph.
yep, I did it ^-^
Working version of filterAlgorithm is in courseGraph/Utils
there's a secondary list (in *need* of styling) that lists selected courses. Courses can be deselected from graph by clicking them.
y'all welcome
… on how Array functions work when using them. Also, this was a simple mistake and would've been avoided if we had used typescript; unittests would've also helped by immediately flagging the code that failed (though they would've had to be well designed, and designing good unittests is admittedly hard))
xuyanwen2012
requested review from
Kuahoo,
SeijiEmery,
ThePatrickLauderdale and
wendyrliang
and removed request for
Kuahoo,
ThePatrickLauderdale and
wendyrliang
Pull Request Test Coverage Report for Build 201
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.