chore: update GitHub actions runtime#75
Conversation
📝 WalkthroughWalkthroughThis PR updates GitHub Actions workflows with newer action versions (checkout v6, upload-artifact v7, download-artifact v8, action-gh-release v3) and refactors release workflow checksum generation to compute per-archive SHA256 sums and consolidate Homebrew checksum output handling. ChangesGitHub Actions Workflow Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 123-128: The current block constructs variables macos_arm64,
macos_x64, linux_arm64, linux_x64 by grepping SHA256SUMS and appends them to
GITHUB_OUTPUT without validation; change the logic to first assign these four
variables (using the same grep/awk expressions), then explicitly check each
variable is non-empty (or unset) and if any is missing write an error to stderr
and exit non‑zero to fail fast, only appending to GITHUB_OUTPUT after all four
checks pass; reference the variable names macos_arm64, macos_x64, linux_arm64,
linux_x64, the SHA256SUMS file lookup, and the GITHUB_OUTPUT write to locate and
update the code.
- Line 40: Replace mutable action tags with pinned commit SHAs for every
external action used (e.g., actions/checkout, actions/upload-artifact,
actions/download-artifact, softprops/action-gh-release) and add
persist-credentials: false to the checkout steps (the two uses of
actions/checkout) so credentials are not left in the runner; update the action
refs in the workflow to their corresponding commit SHAs and add the
persist-credentials: false key under the checkout steps to harden supply-chain
and disable credential persistence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e37eb3d7-554a-4fe0-8f47-220438ff6b8a
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/release.yml
Summary
softprops/action-gh-releaseto the Node 24-backed major.actionlintpasses without shellcheck warnings.Testing
actionlint .github/workflows/ci.yml .github/workflows/release.ymlcargo fmtcargo clippy --all-targets -- -D warningscargo testRelease workflow verification
The full release workflow cannot be safely dry-run from a PR because it is intentionally triggered by
v*tags and publishes a GitHub release plus updatescoval-ai/homebrew-tap. After merge, the next tagged release should verify that the Node 20 deprecation annotations are gone.Summary by CodeRabbit