Conversation
feat: **Target ubuntu-latest directly when running dependency-review ** https://coveord.atlassian.net/browse/DT-7006 Summary of changes: - The `dependency-review` workflow now targets `ubuntu-latest` directly instead of using the default. We are changing the default value of the `dependency-review` action to target our self-hosted runners. Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore. *You should adjust and merge this pull request yourself if you're OK with it. Feel free to comment if there's an issue!*
jonapich
requested review from
a team,
dblanchette,
louis-bompart,
olamothe and
y-lakhdar
Contributor
|
Thanks for your contribution @jonapich !
|
Contributor
|
Pull Request Report PR Title ❌ Title should follow the conventional commit spec: (optional scope): Example: feat(cli): add new command |
louis-bompart
approved these changes
Jul 16, 2024
Collaborator
louis-bompart
left a comment
louis-bompart
left a comment
There was a problem hiding this comment.
semantic commit msg/pr title, but code lgtm
jonapich
changed the title
jonapich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: **Target ubuntu-latest directly when running dependency-review **
https://coveord.atlassian.net/browse/DT-7006
Summary of changes:
dependency-reviewworkflow now targetsubuntu-latestdirectly instead of using the default.We are changing the default value of the
dependency-reviewaction to target our self-hosted runners.Therefore, public repositories must be adjusted prior else they will not be able to run the workflow anymore.
You should adjust and merge this pull request yourself if you're OK with it.
Feel free to comment if there's an issue!