Skip to content

Conversation

@jambonrose
Copy link
Collaborator

Hi,
This PR is similar to #52 , but takes a slightly different approach. Instead of retrofitting the new Django feature to avoid changing current code in this repo, this PR opts to add code so that previous versions of Django now operate in the new fashion.

Advantages:

  • built to work with future versions of Django
  • in the future, you can simply delete code to remove technical debt

Disadvantages:

  • adds enum34 as a conditional dependency for Python<3.4
  • adds more code than the other PR
  • slightly slower than the other PR, as an extra function is called to enable compatibility between Django versions

This PR also takes the liberty of:

  • sorting imports with isort
  • using _ to denote an unused variable
  • remove import compatibility for VerbatimNode check for Django<1.5 (as only Django>=1.8 is supported)
  • remove Python 3.6 tests for Django<1.11, as Python 3.6 is not officially supported in those versions

NB: tests run in new Tox environments will fail until #54 is merged.

I realize some of these decisions are a bit controversial, and won't mind at all if you opt to close this. I figured I'd give you an option, though!

Thanks again for your time and for the package.

@jambonrose
Copy link
Collaborator Author

jambonrose commented Jul 30, 2018

Hm. Between the time I commit these and the PR, I see that my GPG key has expired. ☹️ Let me know if you'd like me to resign the commits and force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant