-
Notifications
You must be signed in to change notification settings - Fork 36
Another take on adding support for Django 2.1 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nedbat please merge this one |
|
At this point any of the working branches should be merged so people can upgrade, then a new patch can always be made with a refactoring patch. |
|
Also if any of the maintainers is reading this I would also consider transferring this project to the Jazzband so that we can share the maintenance burden together. |
|
@federicobond Jazzband is an interesting option. I've added another collaborator to this repo. I hope that will unjam some of the recent proposed changes. |
|
When I merge master (for #54 ) into this branch and run Tox, all the tests pass. I've also gone ahead and run the tests on Travis via my repo and everything looks good! 🎉 Given the passing tests and the advantages of this solution over the other proposed solutions, I am merging this one. Thank you for contributing! |
|
Great! Can we expect a new release containing this commit soon? |
|
I've just asked Ned for access to PyPI, and as soon as I have access to it I will release v1.6rc1 there. In the meantime, you can install from Github, referencing the version tag I've just set. $ python -m pip install git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1
$ # or
$ python3 -m pip install git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1The code below may be more appropriate if you'd prefer to use $ cat requirements.txt
git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1
$ python3 -m pip install -Ur requirements.txt I'll be making sure the release works on my end, but would appreciate others double-checking the release. |
|
I have issued a release-candidate with the changes: https://pypi.org/project/django_coverage_plugin/1.6rc1/ |
This is the solution I came up with, which turned out to be similar to #56, except it does not add any additional dependencies to
django-coverage-plugin.I think it strikes a good balance between simplicity and facilitating its own removal later.
@jambonrose what do you think about this approach?
@PamelaM @nedbat any chance we can get either one merged soon?