Skip to content

Conversation

@federicobond
Copy link
Contributor

This is the solution I came up with, which turned out to be similar to #56, except it does not add any additional dependencies to django-coverage-plugin.

I think it strikes a good balance between simplicity and facilitating its own removal later.

@jambonrose what do you think about this approach?

@PamelaM @nedbat any chance we can get either one merged soon?

@jperelli
Copy link

jperelli commented Sep 1, 2018

@nedbat please merge this one

@jambonrose
Copy link
Collaborator

I'm in favor of not needing to rely on Enum3.4 for older code, so I think this is a step in the right direction. At a glance, this code looks to be equivalent with #56 , but I'm reticent to close that one until #54 is merged and we can run tests.

@Madsvj
Copy link

Madsvj commented Sep 1, 2018

At this point any of the working branches should be merged so people can upgrade, then a new patch can always be made with a refactoring patch.

@federicobond
Copy link
Contributor Author

Also if any of the maintainers is reading this I would also consider transferring this project to the Jazzband so that we can share the maintenance burden together.

@nedbat
Copy link
Member

nedbat commented Sep 3, 2018

@federicobond Jazzband is an interesting option. I've added another collaborator to this repo. I hope that will unjam some of the recent proposed changes.

@jambonrose
Copy link
Collaborator

When I merge master (for #54 ) into this branch and run Tox, all the tests pass. I've also gone ahead and run the tests on Travis via my repo and everything looks good! 🎉

Given the passing tests and the advantages of this solution over the other proposed solutions, I am merging this one.

Thank you for contributing!

@jambonrose jambonrose merged commit ea123f6 into coveragepy:master Sep 4, 2018
@marcosfede
Copy link

Great! Can we expect a new release containing this commit soon?
Thanks

@jambonrose
Copy link
Collaborator

I've just asked Ned for access to PyPI, and as soon as I have access to it I will release v1.6rc1 there.

In the meantime, you can install from Github, referencing the version tag I've just set.

$ python -m pip install git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1
$ # or
$ python3 -m pip install git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1

The code below may be more appropriate if you'd prefer to use requirements.txt.

$ cat requirements.txt 
git+https://github.com/nedbat/django_coverage_plugin.git@v1.6rc1
$ python3 -m pip install -Ur requirements.txt 

I'll be making sure the release works on my end, but would appreciate others double-checking the release.

@jambonrose
Copy link
Collaborator

I have issued a release-candidate with the changes: https://pypi.org/project/django_coverage_plugin/1.6rc1/

@federicobond federicobond deleted the fix-django-21 branch November 13, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants