Add troubleshooting guide #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 86.96% 86.98% +0.02%
==========================================
Files 16 16
Lines 2178 2182 +4
==========================================
+ Hits 1894 1898 +4
Misses 284 284 |
tonerdo
approved these changes
May 12, 2019
Co-Authored-By: Toni Solarin-Sodara <toni.edward@outlook.com>
Co-Authored-By: Toni Solarin-Sodara <toni.edward@outlook.com>
Collaborator
Author
|
@tonerdo we can merge this |
Collaborator
Author
|
ping @tonerdo |
Collaborator
|
@MarcoRossignoli do you have merge rights? I was of the impression that you do |
Collaborator
Author
|
Yes @tonerdo but we never talked about "when I can merge", if it's ok for you we could state that if you "Approve" and also to me it's ok(I approve) I can merge, what do you think? |
Collaborator
|
@MarcoRossignoli I'm fine with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added troubleshooting guide to take advantage of new log infrastructure.
/cc @tonerdo @petli