Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThis pull request systematically updates all external domain references throughout the documentation from Changes
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~18 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
docs/cow-protocol/reference/core/auctions/schema.md (1)
11-11: Use descriptive link labels instead of “here”.Line 11, Line 167, and Line 177 use generic anchor text, which hurts scanability and triggers MD059.
Suggested wording update
-The api spec and schema can be found [here](https://docs.cow.fi/cow-protocol/reference/apis/solver). +The API spec and schema can be found in the [Solver API reference](https://docs.cow.fi/cow-protocol/reference/apis/solver). -- `order`: in case of a "fulfillment" trade, the `uid` of the order is provided here as a string. In case it is a just-in-time liquidity order, the specifications of the order are explicitly given as a dictionary; more details can be found [here](https://docs.cow.fi/cow-protocol/reference/apis/solver). +- `order`: in case of a "fulfillment" trade, the `uid` of the order is provided here as a string. In case it is a just-in-time liquidity order, the specifications of the order are explicitly given as a dictionary; more details can be found in the [Solver API reference](https://docs.cow.fi/cow-protocol/reference/apis/solver). -- Depending on the "kind", the rest of the keys are different, and the details and specifications of those can be found [here](https://docs.cow.fi/cow-protocol/reference/apis/solver). +- Depending on the "kind", the rest of the keys are different, and details are documented in the [Solver API reference](https://docs.cow.fi/cow-protocol/reference/apis/solver).Also applies to: 167-167, 177-177
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/cow-protocol/reference/core/auctions/schema.md` at line 11, Replace the generic link text "here" with a descriptive label for accessibility and MD059 compliance: locate the Markdown links that point to https://docs.cow.fi/cow-protocol/reference/apis/solver (currently written as [here](...)) and change the anchor text to a meaningful phrase such as "COW Protocol solver API spec and schema" (or similar descriptive wording) wherever it appears in this file (including the three occurrences flagged), keeping the same URL and updating any other identical "here" links to consistent, descriptive labels.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 18: Remove the unused link reference "[CoW Protocol Forums]" from the
document or add a corresponding inline reference where intended; specifically
delete the line containing "[CoW Protocol Forums]: https://forum.cow.fi" (or
replace it by adding a textual reference like [CoW Protocol Forums] in the
relevant section) so the link reference definition is either used or removed to
avoid dead/unused references.
In `@docs/cow-protocol/tutorials/cow-amm-deployer.mdx`:
- Line 6: The Safe App deep link in the CoW AMM Deployer description uses the
wrong EIP-3770 chain short name (`chain=et`) so the Safe won't open Ethereum
Mainnet; update the URL in the CoW AMM Deployer sentence (the href containing
"https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et")
to use `chain=eth` instead of `chain=et` so the link selects Ethereum Mainnet
correctly.
In `@docs/cow-protocol/tutorials/solvers/evaluate.md`:
- Line 10: The documentation link to the solver auction/rewards page is broken
(the URL
"https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards"
in docs/cow-protocol/tutorials/solvers/evaluate.md); update that URL to the
correct page (for example replace it with
"https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards" or
"https://docs.cow.fi/cow-protocol/reference/core/auctions/competition-rules") so
the "notify" endpoint paragraph points to the valid solver auction and rewards
documentation.
In `@docs/cow-protocol/tutorials/solvers/local_test.md`:
- Line 26: Update the example command to use the correct argument formats for
the flags: change the --native-price-estimators entry to the required
Driver|name|url form (e.g., include the "Driver" prefix, the estimator name, and
its URL) and change the --drivers entry to the required name|url|address|value
form (include the solver name, its URL, on-chain address, and value); ensure
both flags use those exact pipe-separated fields so the command will parse at
runtime.
In `@docs/cow-protocol/tutorials/solvers/onboard.md`:
- Line 126: Replace the generic "here" link text at the two occurrences pointing
to https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards and
https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting with
descriptive link text (e.g., "how we calculate and distribute rewards" and "the
accounting process for auctions" respectively) so the markdown headings satisfy
MD059 and improve readability; update both instances (the rewards link and the
accounting link) in docs/cow-protocol/tutorials/solvers/onboard.md.
---
Nitpick comments:
In `@docs/cow-protocol/reference/core/auctions/schema.md`:
- Line 11: Replace the generic link text "here" with a descriptive label for
accessibility and MD059 compliance: locate the Markdown links that point to
https://docs.cow.fi/cow-protocol/reference/apis/solver (currently written as
[here](...)) and change the anchor text to a meaningful phrase such as "COW
Protocol solver API spec and schema" (or similar descriptive wording) wherever
it appears in this file (including the three occurrences flagged), keeping the
same URL and updating any other identical "here" links to consistent,
descriptive labels.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5c2be69c-3845-46e0-b42b-8a1915538b87
📒 Files selected for processing (52)
CONTRIBUTING.mddocs/README.mddocs/cow-amm/tutorials/cow-amm-deployer.mddocs/cow-protocol/affiliate-program/faq.mddocs/cow-protocol/concepts/benefits/mev-protection.mddocs/cow-protocol/concepts/how-it-works/flow-of-an-order.mddocs/cow-protocol/concepts/how-it-works/how-intents-are-formed.mdxdocs/cow-protocol/concepts/order-types/cow-hooks.mdxdocs/cow-protocol/concepts/order-types/limit-orders.mddocs/cow-protocol/concepts/order-types/milkman-orders.mddocs/cow-protocol/concepts/order-types/programmatic-orders.mddocs/cow-protocol/concepts/order-types/twap-orders.mddocs/cow-protocol/integrate/api.mdxdocs/cow-protocol/integrate/sdk.mdxdocs/cow-protocol/integrate/widget.mdxdocs/cow-protocol/reference/core/auctions/accounting.mddocs/cow-protocol/reference/core/auctions/bonding_pools.mddocs/cow-protocol/reference/core/auctions/rewards.mddocs/cow-protocol/reference/core/auctions/schema.mddocs/cow-protocol/reference/core/intents/app_data.mdxdocs/cow-protocol/tutorials/arbitrate/README.mdxdocs/cow-protocol/tutorials/building.mdxdocs/cow-protocol/tutorials/cow-amm-deployer.mdxdocs/cow-protocol/tutorials/cow-explorer/README.mdxdocs/cow-protocol/tutorials/cow-explorer/address.mddocs/cow-protocol/tutorials/cow-explorer/batch_auction.mddocs/cow-protocol/tutorials/cow-explorer/order.mddocs/cow-protocol/tutorials/cow-swap/README.mdxdocs/cow-protocol/tutorials/cow-swap/custom-links.mddocs/cow-protocol/tutorials/cow-swap/flash-loans.mdxdocs/cow-protocol/tutorials/cow-swap/native.mdxdocs/cow-protocol/tutorials/cow-swap/swap-and-bridge.mdxdocs/cow-protocol/tutorials/cow-swap/swap.mdxdocs/cow-protocol/tutorials/cow-swap/twap.mdxdocs/cow-protocol/tutorials/hook-dapp/hook-dapp.mddocs/cow-protocol/tutorials/solvers/evaluate.mddocs/cow-protocol/tutorials/solvers/flashloans_support.mddocs/cow-protocol/tutorials/solvers/local_test.mddocs/cow-protocol/tutorials/solvers/onboard.mddocs/cow-protocol/tutorials/solvers/test.mddocs/cow-protocol/tutorials/swap-in-safe-app/README.mdxdocs/cow-protocol/tutorials/widget/widget.mddocs/governance/README.mdxdocs/governance/fees/partner-fee.mddocs/governance/grants/how-to-apply.mddocs/governance/grants/program-structure.mddocs/governance/multisigs.mdxdocs/governance/process/README.mdxdocs/governance/token.mddocs/llms.mddocusaurus.config.tsvercel.json
|
|
||
| [CoW Protocol Discord]: https://discord.gg/cowprotocol | ||
| [CoW Protocol Forums]: https://forum.cow.finance | ||
| [CoW Protocol Forums]: https://forum.cow.fi |
Contributor
There was a problem hiding this comment.
Remove unused link reference definition.
The [CoW Protocol Forums] link reference is defined but never used in the document. Consider either removing the definition or adding a reference to it in the text.
🧹 Proposed fix to remove unused reference
-[CoW Protocol Forums]: https://forum.cow.fiAlternatively, if you intend to use this reference, add it to the relevant sections in the document.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| [CoW Protocol Forums]: https://forum.cow.fi |
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 18-18: Link and image reference definitions should be needed
Unused link or image reference definition: "cow protocol forums"
(MD053, link-image-reference-definitions)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@CONTRIBUTING.md` at line 18, Remove the unused link reference "[CoW Protocol
Forums]" from the document or add a corresponding inline reference where
intended; specifically delete the line containing "[CoW Protocol Forums]:
https://forum.cow.fi" (or replace it by adding a textual reference like [CoW
Protocol Forums] in the relevant section) so the link reference definition is
either used or removed to avoid dead/unused references.
|
|
||
| # CoW AMM Deployer | ||
| The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.finance/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. | ||
| The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For Safe app deep links on app.safe.global/share/safe-app, what are the valid values for the chainquery parameter? Ischain=etvalid, or should Ethereum bechain=eth?
💡 Result:
The valid values for the chain query parameter in Safe app deep links on app.safe.global/share/safe-app are EIP-3770 short names (chain prefixes) as defined in Safe's configuration and SDK. For Ethereum Mainnet (chainId 1), it is chain=eth. There is no evidence of chain=et being valid; it does not appear in Safe's supported networks list or EIP-3770 mappings. Ethereum uses eth consistently. Examples from Safe's protocol-kit EIP-3770 config: - Ethereum Mainnet (1): eth - Optimism (10): oeth - Polygon (137): matic - BSC (56): bsc Safe supports 25+ networks via these short names for deep linking to specific Safe Apps on particular chains. The deep link format likely follows patterns like https://app.safe.global/share/safe-app?appUrl=...&chain=eth to open a specific app on the specified chain.
Citations:
- 1: https://github.com/safe-global/safe-core-sdk/blob/main/packages/protocol-kit/src/utils/eip-3770/config.ts
- 2: https://docs.safe.global/config-service-configuration/add-or-edit-chain
- 3: https://docs.safe.global/api-supported-networks
- 4: feat: add EIP-3779 shortname for appchain safe-global/safe-core-sdk#1072
- 5: https://eips.ethereum.org/EIPS/eip-3770
Fix Safe app link query: chain=et should be chain=eth.
Safe app deep links use EIP-3770 chain short names, and Ethereum Mainnet is eth, not et. This link won't select the correct network.
🔧 Suggested fix
-The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM.
+The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=eth) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. 📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. | |
| The [CoW AMM Deployer](https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=eth) is a user-friendly Safe App that simplifies the process of deploying and managing [CoW AMMs](https://cow.fi/cow-amm) (Automated Market Makers) from Safe wallets. It enables users without programming skills to take advantage of the benefits of CoW AMM. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/cow-protocol/tutorials/cow-amm-deployer.mdx` at line 6, The Safe App
deep link in the CoW AMM Deployer description uses the wrong EIP-3770 chain
short name (`chain=et`) so the Safe won't open Ethereum Mainnet; update the URL
in the CoW AMM Deployer sentence (the href containing
"https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fdeploy-cow-amm.bleu.fi&chain=et")
to use `chain=eth` instead of `chain=et` so the link selects Ethereum Mainnet
correctly.
| ## Getting notified about the ranking | ||
|
|
||
| A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.finance/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards) section). | ||
| A very useful functionality provided by the driver is the "notify" endpoint, which notifies all solvers participating in an auction about the ranking, once the bidding has closed, i.e., once all solutions have been submitted and have been ranked. (To find out about how solutions are ranked, see [this](https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards) section). |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the updated documentation URL is accessible
# Test: Check if the new URL returns a successful response
curl -I -L --max-time 10 "https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards" 2>&1 | head -n 1Repository: cowprotocol/docs
Length of output: 139
🏁 Script executed:
# Read the actual file line 10 to see what the comment is referencing
cat -n docs/cow-protocol/tutorials/solvers/evaluate.md | sed -n '8,12p'Repository: cowprotocol/docs
Length of output: 619
🏁 Script executed:
# Run a better curl command to check HTTP response without progress bar
curl -s -o /dev/null -w "HTTP Status: %{http_code}\n" -L "https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards"Repository: cowprotocol/docs
Length of output: 76
🏁 Script executed:
# Check if the old domain (docs.cow.finance) works with the same path
curl -s -o /dev/null -w "HTTP Status: %{http_code}\n" -L "https://docs.cow.finance/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards"Repository: cowprotocol/docs
Length of output: 76
🏁 Script executed:
# Search the docs repository for references to "solver-auction" to find the correct path
rg "solver-auction" docs/ -i --type markdown -A 2 -B 2Repository: cowprotocol/docs
Length of output: 824
🏁 Script executed:
# Find files related to solver documentation
fd "solver" docs/ -i --type f | head -20Repository: cowprotocol/docs
Length of output: 328
🏁 Script executed:
# List the structure of the off-chain-services directory
find docs/cow-protocol/off-chain-services -type f -name "*.md" 2>/dev/null | head -20Repository: cowprotocol/docs
Length of output: 42
🏁 Script executed:
# Search for any reference to "in-depth" or "specification" in the docs
rg "specification|auction" docs/ -i --type markdown | grep -i solver | head -10Repository: cowprotocol/docs
Length of output: 1772
🏁 Script executed:
# List top-level directories in docs/cow-protocol
ls -la docs/cow-protocol/ | grep "^d"Repository: cowprotocol/docs
Length of output: 464
🏁 Script executed:
# Check the reference directory for solver-related docs
find docs/cow-protocol/reference -type f -name "*.md*" | xargs ls -laRepository: cowprotocol/docs
Length of output: 3692
🏁 Script executed:
# Search for "solver" in reference directory
rg "solver" docs/cow-protocol/reference -i -lRepository: cowprotocol/docs
Length of output: 1309
🏁 Script executed:
# Check what's in the solver.mdx file
cat docs/cow-protocol/reference/apis/solver.mdxRepository: cowprotocol/docs
Length of output: 289
🏁 Script executed:
# Check the auctions README
cat docs/cow-protocol/reference/core/auctions/README.mdxRepository: cowprotocol/docs
Length of output: 863
🏁 Script executed:
# Search git history to see if this path ever existed or what the original link was
git log --all --full-history --source -- "*off-chain-services*" 2>/dev/null | head -20Repository: cowprotocol/docs
Length of output: 665
🏁 Script executed:
# Check if there's a sidebar or routing file that might show the doc structure
find docs -name "sidebars*" -o -name "docusaurus*" -o -name "*config*" | head -10Repository: cowprotocol/docs
Length of output: 42
🏁 Script executed:
# Search for content about "solver" in auction-related files
rg -i "solver.*auction|auction.*solver" docs/cow-protocol/reference/core/auctions/ -A 3Repository: cowprotocol/docs
Length of output: 20585
🏁 Script executed:
# Look for links in the evaluate.md file to see if there are other working links we can compare
cat -n docs/cow-protocol/tutorials/solvers/evaluate.md | head -40Repository: cowprotocol/docs
Length of output: 1231
Fix broken documentation link.
The URL https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards returns a 404 error and the path does not exist in the documentation structure. Update the link to point to the correct documentation page covering solver auction and rewards, which should be something like https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards or https://docs.cow.fi/cow-protocol/reference/core/auctions/competition-rules.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/cow-protocol/tutorials/solvers/evaluate.md` at line 10, The
documentation link to the solver auction/rewards page is broken (the URL
"https://docs.cow.fi/off-chain-services/in-depth-solver-specification/solver-auction-and-rewards"
in docs/cow-protocol/tutorials/solvers/evaluate.md); update that URL to the
correct page (for example replace it with
"https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards" or
"https://docs.cow.fi/cow-protocol/reference/core/auctions/competition-rules") so
the "notify" endpoint paragraph points to the valid solver auction and rewards
documentation.
|
|
||
| ``` | ||
| cargo run --bin autopilot -- --native-price-estimators "baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.finance/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1" | ||
| cargo run --bin autopilot -- --native-price-estimators "baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1" |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking --native-price-estimators examples:"
rg -n --type=md --type=mdx -- '--native-price-estimators\s+"[^"]+"' -C2
echo
echo "Checking --drivers examples:"
rg -n --type=md --type=mdx -- '--drivers\s+"[^"]+"' -C2Repository: cowprotocol/docs
Length of output: 149
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== File structure check ==="
find docs/cow-protocol/tutorials/solvers -name "*local_test*" -type f
echo
echo "=== Checking file at lines around 26 ==="
if [ -f docs/cow-protocol/tutorials/solvers/local_test.md ]; then
sed -n '20,35p' docs/cow-protocol/tutorials/solvers/local_test.md
fi
echo
echo "=== Searching for --native-price-estimators examples (all markdown) ==="
rg -n -- '--native-price-estimators' docs/
echo
echo "=== Searching for --drivers examples (all markdown) ==="
rg -n -- '--drivers' docs/Repository: cowprotocol/docs
Length of output: 1656
Fix autopilot argument formats in the command example.
Line 26 uses incorrect formats for both --native-price-estimators and --drivers. The command will fail at runtime if users follow this example.
Required fix
- cargo run --bin autopilot -- --native-price-estimators "baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1"
+ cargo run --bin autopilot -- --native-price-estimators "Driver|baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088|0x0000000000000000000000000000000000000000|0"--native-price-estimators requires the format Driver|name|url and --drivers requires name|url|address|value.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| cargo run --bin autopilot -- --native-price-estimators "baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088/mysolver1" | |
| cargo run --bin autopilot -- --native-price-estimators "Driver|baseline|http://driver/baseline" --skip-event-sync true --node-url $NODE_URL --shadow https://api.cow.fi/mainnet --drivers "mysolver1|http://localhost:11088|0x0000000000000000000000000000000000000000|0" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/cow-protocol/tutorials/solvers/local_test.md` at line 26, Update the
example command to use the correct argument formats for the flags: change the
--native-price-estimators entry to the required Driver|name|url form (e.g.,
include the "Driver" prefix, the estimator name, and its URL) and change the
--drivers entry to the required name|url|address|value form (include the solver
name, its URL, on-chain address, and value); ensure both flags use those exact
pipe-separated fields so the command will parse at runtime.
| We advise using a single rewards address that is available on all networks. | ||
|
|
||
| [You can find more information about how we calculate and distribute rewards here.](https://docs.cow.finance/cow-protocol/reference/core/auctions/rewards). The accounting process is documented in detail [here](https://docs.cow.finance/cow-protocol/reference/core/auctions/accounting). | ||
| [You can find more information about how we calculate and distribute rewards here.](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards). The accounting process is documented in detail [here](https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting). |
Contributor
There was a problem hiding this comment.
Use descriptive link text to satisfy markdownlint (MD059).
These two links still use generic “here”, which weakens readability and fails lint.
📝 Suggested fix
-[You can find more information about how we calculate and distribute rewards here.](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards). The accounting process is documented in detail [here](https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting).
+[How weekly rewards are calculated and distributed](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards). The [accounting process documentation](https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting) provides full details.
@@
-Besides the solving competition, there is also a quoting competition. More information about the quoting competition can be found [here](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards#price-estimation-competition-rewards-cips-27-57-72).
+Besides the solving competition, there is also a quoting competition. See [quoting competition rewards](https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards#price-estimation-competition-rewards-cips-27-57-72) for details.Also applies to: 138-138
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 126-126: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/cow-protocol/tutorials/solvers/onboard.md` at line 126, Replace the
generic "here" link text at the two occurrences pointing to
https://docs.cow.fi/cow-protocol/reference/core/auctions/rewards and
https://docs.cow.fi/cow-protocol/reference/core/auctions/accounting with
descriptive link text (e.g., "how we calculate and distribute rewards" and "the
accounting process for auctions" respectively) so the markdown headings satisfy
MD059 and improve readability; update both instances (the rewards link and the
accounting link) in docs/cow-protocol/tutorials/solvers/onboard.md.
Danziger
approved these changes
Apr 15, 2026
limitofzero
approved these changes
Apr 15, 2026
Contributor
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating fixes for 5 unresolved review comments... This may take a few minutes. The auto-fix coding agent will autonomously read files and make edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simply revert back the changes, nothing else
Summary by CodeRabbit