fix: update known issues related to orders with zero amounts#624
fix: update known issues related to orders with zero amounts#624marshymarsh merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation update clarifying zero-amount order vulnerabilities. The known issue now applies when either ChangesDocumentation Clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
| ## Security / Known Issues | ||
|
|
||
| ### Partially fillable orders with zero amounts | ||
| ### Orders with zero amounts |
There was a problem hiding this comment.
do we mention somewhere they must not use any fee too?
There was a problem hiding this comment.
We only do so indirectly, for example:
- https://docs.cow.fi/cow-amm/tutorials/cow-amm-for-solvers#settling-a-custom-order
- https://docs.cow.fi/governance/fees/partner-fee#a-user-sells-1-eth-for-dai-on-your-widget
But we also have contradicting documentation:
- https://docs.cow.fi/governance/fees/partner-fee#a-user-sells-1-eth-for-dai-on-your-widget
- https://docs.cow.fi/cow-protocol/reference/core/intents#batch-auction
I agree we should change that, this is not part of this PR however.
Related: cowprotocol/contracts#29
Summary by CodeRabbit