Skip to content

fix: update known issues related to orders with zero amounts#624

Merged
marshymarsh merged 1 commit intomainfrom
fix/known-issue-zero-amounts
May 5, 2026
Merged

fix: update known issues related to orders with zero amounts#624
marshymarsh merged 1 commit intomainfrom
fix/known-issue-zero-amounts

Conversation

@igorroncevic
Copy link
Copy Markdown
Contributor

@igorroncevic igorroncevic commented May 4, 2026

Related: cowprotocol/contracts#29

Summary by CodeRabbit

  • Documentation
    • Updated security guidance to clarify vulnerability conditions for orders with zero amounts
    • Refined documentation to specify when orders are susceptible to repeated execution vulnerabilities

@igorroncevic igorroncevic requested a review from a team as a code owner May 4, 2026 16:38
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview May 4, 2026 4:39pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 373922af-4430-42fe-ad13-b8f42208e49d

📥 Commits

Reviewing files that changed from the base of the PR and between 3fea150 and 6870b29.

📒 Files selected for processing (1)
  • docs/cow-protocol/reference/contracts/core/README.mdx

📝 Walkthrough

Walkthrough

Documentation update clarifying zero-amount order vulnerabilities. The known issue now applies when either sellAmount = 0 or buyAmount = 0, removing the prior requirement that both amounts be zero and partiallyFillable be true. Section title simplified from "Partially fillable orders with zero amounts" to "Orders with zero amounts."

Changes

Documentation Clarification

Layer / File(s) Summary
Known Issues Documentation
docs/cow-protocol/reference/contracts/core/README.mdx
"Orders with zero amounts" subsection updated: vulnerability condition changed from AND logic (both amounts zero AND partiallyFillable = true) to OR logic (either sellAmount = 0 or buyAmount = 0). Impact claim preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A doc fix hops into view,
Where zero amounts now ring most true—
OR, not AND, the logic now reads,
Simpler wisdom for security's deeds! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing, with no content provided by the author. Add a pull request description following the repository template, including a description of changes and the rationale for updating the known issues documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating documentation about known issues related to orders with zero amounts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/known-issue-zero-amounts

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

igorroncevic added a commit to cowprotocol/contracts that referenced this pull request May 5, 2026
## Security / Known Issues

### Partially fillable orders with zero amounts
### Orders with zero amounts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we mention somewhere they must not use any fee too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marshymarsh marshymarsh merged commit 5e11bb1 into main May 5, 2026
5 checks passed
@marshymarsh marshymarsh deleted the fix/known-issue-zero-amounts branch May 5, 2026 16:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants