Remove soft cancellation #3993
Merged
Remove soft cancellation #3993
+0
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
use-soft-cancellationflag from the mempool configs. This flag is currently not used to make any decisions. And more importantly it will actually never make sense to execute different logic based on that.The reason is that we actually don't care about cancellations getting mined. If we submit a cancellation we are really only interested in preventing the previous settlement tx to no longer be in the mempool.
If the same tx got replaced many times over it's technically possible that it's more cost effective to have an already expensive cancellation tx get mined than replacing it with another settlement tx (making it even more expensive in the process) but given the bad state of our current submission logic this is nothing we should optimize for at the moment.
Changes
Deleted unused
use_soft_cancellationsflag