Skip to content

Add no-op placeholder migrations for the numbering to be continuous#4096

Merged
m-sz merged 3 commits intomainfrom
add-no-op-placeholder-migrations
Jan 28, 2026
Merged

Add no-op placeholder migrations for the numbering to be continuous#4096
m-sz merged 3 commits intomainfrom
add-no-op-placeholder-migrations

Conversation

@m-sz
Copy link
Copy Markdown
Contributor

@m-sz m-sz commented Jan 27, 2026

Description

We needed to revert migrations V098, V099, and V097 was spelled wrongly (lowercase v). Since then V100 has been added and it makes flyway complain about missing interim migrations.

Adding no-op migrations is enough to keep the continuity.

Changes

Adds no-op migrations V097, V098 and V099

@m-sz m-sz requested a review from a team as a code owner January 27, 2026 16:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 27, 2026

Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).

  • If creating new tables, update the tables list.
  • When adding a new index, consider using CREATE INDEX CONCURRENTLY for tables involved in the critical execution path.
  • For breaking changes, remember that during rollout k8s starts the new autopilot, runs the Flyway migration, and only then shuts down the old pod. That overlap means the previous version can still be processing requests on the migrated schema, so make it compatible first and ship the breaking DB change in the following release.

Caused by:

@squadgazzz
Copy link
Copy Markdown
Contributor

Please add a clearer description explaining why this is even required (because we have to keep the V100 migration, which breaks flyway). I assume without V100 it should have worked with no issue.

@MartinquaXD
Copy link
Copy Markdown
Contributor

Given hat flyway also complains about the incorrect file name of 097 (IIRC) could you please also replace that file with a correctly named placeholder?

@jmg-duarte
Copy link
Copy Markdown
Contributor

Please add a clearer description explaining why this is even required (because we have to keep the V100 migration, which breaks flyway). I assume without V100 it should have worked with no issue.

Could we also add them to the SQL file? It can be short, but something would be helpful for future reference, for example

-- Migration was omitted to keep numbering continuity, for more information see issues #4096, ...

@m-sz
Copy link
Copy Markdown
Contributor Author

m-sz commented Jan 28, 2026

@jmg-duarte sure, I like that

@m-sz m-sz added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 8d6851c Jan 28, 2026
19 checks passed
@m-sz m-sz deleted the add-no-op-placeholder-migrations branch January 28, 2026 10:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants