[TRIVIAL] Drop the db solver participation guard#4099
Merged
squadgazzz merged 3 commits intomainfrom Jan 30, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
jmg-duarte
approved these changes
Jan 28, 2026
Contributor
|
My favorite kind of PR 🧹 |
MartinquaXD
approved these changes
Jan 29, 2026
Contributor
MartinquaXD
left a comment
MartinquaXD
left a comment
There was a problem hiding this comment.
While I agree with the sentiment "remove what we don't use" I thought this was generally agreed to be useful. Wasn't the solver team even supposed to look into a reasonable rule that would be added with a CIP? Can you follow up with the solver team about this before pulling the trigger on this PR?
squadgazzz
added
blocked
Contributor
Author
|
As per the solver's team response https://cowservices.slack.com/archives/C04V9D9JTEV/p1769777318816849?thread_ts=1756808562.226519&cid=C04V9D9JTEV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the codebase by removing the DB solver participation guard. It's been used in a log-only mode for a while. Given the lack of demand for this functionality, it doesn't make sense to keep it. Also, even if it were decided to enable it, the logic would need to be reworked to cover some edge cases, which would take some time to implement.