Skip to content

[TRIVIAL] Fix verbose log#4120

Merged
MartinquaXD merged 1 commit intomainfrom
fix-one-log
Feb 3, 2026
Merged

[TRIVIAL] Fix verbose log#4120
MartinquaXD merged 1 commit intomainfrom
fix-one-log

Conversation

@MartinquaXD
Copy link
Copy Markdown
Contributor

Description

There was a slight oversight in #4084. Instead of printing only the solver name we now print all the internals which is quite a lot.

Changes

  • only log the solver name again
  • stop logging the weth address as well

@MartinquaXD MartinquaXD requested a review from a team as a code owner February 3, 2026 16:24
@MartinquaXD MartinquaXD changed the title Fix one log Fix verbose log Feb 3, 2026
@MartinquaXD MartinquaXD changed the title Fix verbose log [TRIVIAL] Fix verbose log Feb 3, 2026
@MartinquaXD MartinquaXD enabled auto-merge February 3, 2026 16:25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The changes use derive_more::Debug attributes to reduce log verbosity for the Solution struct. This change is correct and aligns with the PR's goal. No high or critical issues were found.

@MartinquaXD MartinquaXD added this pull request to the merge queue Feb 3, 2026
@MartinquaXD MartinquaXD removed this pull request from the merge queue due to a manual request Feb 3, 2026
@MartinquaXD MartinquaXD added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit be8ec55 Feb 3, 2026
18 of 19 checks passed
@MartinquaXD MartinquaXD deleted the fix-one-log branch February 3, 2026 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants