Skip to content

[TRIVIAL] Fix vulnerability by bumping bytes crate version#4121

Merged
MartinquaXD merged 2 commits intomainfrom
fix-vulnerability
Feb 3, 2026
Merged

[TRIVIAL] Fix vulnerability by bumping bytes crate version#4121
MartinquaXD merged 2 commits intomainfrom
fix-vulnerability

Conversation

@MartinquaXD
Copy link
Copy Markdown
Contributor

Description

The cargo audit action complained about the bytes crate being vulnerable. The recommended fix is to upgrade bytes to version 1.11.1 (patch version bump).

How to test

cargo audit action

@MartinquaXD MartinquaXD requested a review from a team as a code owner February 3, 2026 16:41
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the bytes crate to version 1.11.1 in Cargo.lock to address a vulnerability. However, the method used to pin the version in Cargo.toml by adding it to [workspace.dependencies] is not effective for transitive dependencies. A more robust approach using [patch.crates-io] is recommended to ensure the security fix is not accidentally reverted during future dependency resolutions.

Comment thread Cargo.toml Outdated
@MartinquaXD MartinquaXD enabled auto-merge February 3, 2026 16:49
@MartinquaXD MartinquaXD added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit e239bd3 Feb 3, 2026
19 checks passed
@MartinquaXD MartinquaXD deleted the fix-vulnerability branch February 3, 2026 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants