Skip to content

[TRIVIAL] Remove unused error#4124

Merged
jmg-duarte merged 2 commits intomainfrom
jmgd/alloy/contract-error
Feb 3, 2026
Merged

[TRIVIAL] Remove unused error#4124
jmg-duarte merged 2 commits intomainfrom
jmgd/alloy/contract-error

Conversation

@jmg-duarte
Copy link
Copy Markdown
Contributor

Description

Removes an unused error, this could actually have made it in #4106 but VSCode looked like an Xmas tree, I wasn't expecting this to be this simple.

Changes

  • Removes unused error
  • Removes accompanying From

@jmg-duarte jmg-duarte requested a review from a team as a code owner February 3, 2026 17:05
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unused error type Error from the contracts module and its corresponding From implementation in the blockchain module. The goal is to clean up the codebase by removing dead code. I have identified one high severity issue related to the removal of the From implementation, as it might be used elsewhere.

I am having trouble creating individual review comments. Click here to see my feedback.

crates/driver/src/infra/blockchain/mod.rs (350-356)

high

The removal of impl From<contracts::Error> for Error might break existing code if contracts::Error is being converted to Error elsewhere. It's important to ensure that this conversion is not relied upon before removing it.

If this conversion is indeed unused, then the removal is correct. However, if it is used, you will need to handle the conversion differently or keep the From implementation.

@jmg-duarte jmg-duarte enabled auto-merge February 3, 2026 17:46
@jmg-duarte jmg-duarte added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 993e2d4 Feb 3, 2026
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy/contract-error branch February 3, 2026 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants