Conversation
There was a problem hiding this comment.
Code Review
This pull request removes an unused error type Error from the contracts module and its corresponding From implementation in the blockchain module. The goal is to clean up the codebase by removing dead code. I have identified one high severity issue related to the removal of the From implementation, as it might be used elsewhere.
I am having trouble creating individual review comments. Click here to see my feedback.
crates/driver/src/infra/blockchain/mod.rs (350-356)
The removal of impl From<contracts::Error> for Error might break existing code if contracts::Error is being converted to Error elsewhere. It's important to ensure that this conversion is not relied upon before removing it.
If this conversion is indeed unused, then the removal is correct. However, if it is used, you will need to handle the conversion differently or keep the From implementation.
Description
Removes an unused error, this could actually have made it in #4106 but VSCode looked like an Xmas tree, I wasn't expecting this to be this simple.
Changes