Skip to content

[EASY] Clean up remaining cargo audit advisories#4287

Merged
squadgazzz merged 9 commits intomainfrom
fix-cargo-audit-vulnerabilities
Mar 24, 2026
Merged

[EASY] Clean up remaining cargo audit advisories#4287
squadgazzz merged 9 commits intomainfrom
fix-cargo-audit-vulnerabilities

Conversation

@squadgazzz
Copy link
Copy Markdown
Contributor

Summary

Follow-up to #4286. Resolves additional cargo audit warnings and cleans up stale ignore entries.

  • Remove idna and protobuf from ignore list — RUSTSEC-2024-0421 and RUSTSEC-2024-0437 are no longer triggered by current dependency versions
  • Update keccak 0.1.5 → 0.1.6 — fixes RUSTSEC-2026-0012 (unsound ARMv8 assembly backend) and resolves yanked crate warning
  • Update aws-sdk-s3 1.119.0 → 1.127.0 — removes lru 0.12.5 from the tree, fixing RUSTSEC-2026-0002 (unsound IterMut)

After this PR, cargo audit reports zero vulnerabilities and zero warnings. The remaining ignore entries are genuinely unfixable:

  • rsa — no patch available
  • derivative/instant/paste — unmaintained, pinned by transitive deps
  • model — false positive matching our local crate name

Test plan

  • cargo check --workspace passes
  • cargo audit reports 0 vulnerabilities, 0 warnings

Update transitive dependencies to resolve all 7 advisories:
- aws-lc-sys 0.35.0 → 0.39.0 (fixes RUSTSEC-2026-{0044,0045,0046,0047,0048})
- rustls-webpki 0.103.8 → 0.103.10 (fixes RUSTSEC-2026-0049)
- Switch aws-sdk-s3 from `rustls` to `default-https-client` feature to use
  the modern TLS stack (rustls-aws-lc) instead of the legacy one
  (legacy-rustls-ring) which pulled in rustls 0.21 and the vulnerable
  rustls-webpki 0.101.7 (fixes RUSTSEC-2026-0049 for the 0.101.x line)
- Updated AWS SDK chain to latest compatible versions
The AWS SDK dependency updates introduced deeper type nesting that
exceeds the default compiler recursion limit when building tests.
The compiler needs 130; 160 provides reasonable headroom without being
excessive.
These advisories (RUSTSEC-2024-0421, RUSTSEC-2024-0437) are no longer
triggered by the current dependency versions.
Fixes RUSTSEC-2026-0012 (unsound ARMv8 assembly backend) and resolves
the yanked crate warning.
Removes lru 0.12.5 from the dependency tree, fixing RUSTSEC-2026-0002
(unsound IterMut in lru).
@squadgazzz squadgazzz requested a review from a team as a code owner March 23, 2026 20:38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies to resolve security advisories. My review includes one high-severity suggestion regarding the newly added recursion limit in crates/autopilot/src/lib.rs, which may mask code complexity and should be investigated.

@squadgazzz squadgazzz changed the title Clean up remaining cargo audit advisories [EASY] Clean up remaining cargo audit advisories Mar 23, 2026
@squadgazzz squadgazzz added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit 38d8383 Mar 24, 2026
19 checks passed
@squadgazzz squadgazzz deleted the fix-cargo-audit-vulnerabilities branch March 24, 2026 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants