[TRIVIAL] Redact IPFS auth_token in debug#4325
Merged
jmg-duarte merged 2 commits intomainfrom Apr 10, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a manual Debug trait for IpfsConfig to redact the auth_token field and adds a corresponding test case. The review feedback highlights that the current implementation incorrectly redacts the token even when it is None, potentially leading to misleading debug logs. It is recommended to preserve the Option structure in the Debug output and update the tests to verify both the redacted token and the None case.
squadgazzz
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4310
This fixes the leakage by redacting the IPFS secret in the Debug implementation.
Changes
How to test
Added a test to ensure it doesn't break without us noticing