Skip to content

Workflow to test contract generated code#4336

Merged
jmg-duarte merged 6 commits intomainfrom
jmgd/fix/diff-gen-contracts
Apr 16, 2026
Merged

Workflow to test contract generated code#4336
jmg-duarte merged 6 commits intomainfrom
jmgd/fix/diff-gen-contracts

Conversation

@jmg-duarte
Copy link
Copy Markdown
Contributor

@jmg-duarte jmg-duarte commented Apr 15, 2026

Description

Adds a CI job to ensure that generated contract code was just generated

Changes

  • CI job to detect manual tampering of generated code

How to test

There are commits associated with this PR that should launch jobs that will fail or pass, will add them here as they're done

"Successful failure" — i.e. detected changes: https://github.com/cowprotocol/services/actions/runs/24463810679/job/71485172786?pr=4336
Successful success — i.e. no changes = nothing detected: https://github.com/cowprotocol/services/actions/runs/24464073112/job/71486114618?pr=4336

@jmg-duarte jmg-duarte requested a review from a team as a code owner April 15, 2026 15:41
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a documentation comment from an auto-generated file. Feedback was provided to restore this comment to maintain consistency with the code generation template and prevent CI failures related to tampering detection.

Comment thread .github/workflows/pull-request.yaml Outdated
Comment thread .github/workflows/pull-request.yaml Outdated
Copy link
Copy Markdown
Member

@AryanGodara AryanGodara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 comments

Comment thread .github/workflows/pull-request.yaml Outdated
Co-authored-by: Jan [Yann] <4518474+fafk@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@jmg-duarte jmg-duarte enabled auto-merge April 16, 2026 16:11
@jmg-duarte jmg-duarte added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit 17d9f10 Apr 16, 2026
20 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/fix/diff-gen-contracts branch April 16, 2026 16:35
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants