Remove deprecated Goerli chain#4425
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes all references to the Goerli testnet across the codebase, including its definition in the Chain and ChainId enums, associated liquidity sources, price estimation logic, and relevant unit tests. I have no feedback to provide as the changes are consistent and correctly implement the removal of the deprecated network.
jmg-duarte
approved these changes
May 20, 2026
squadgazzz
reviewed
May 20, 2026
Contributor
squadgazzz
left a comment
There was a problem hiding this comment.
Dockerfile.cowswap still contains some Goerli mentions.
jmg-duarte
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goerli is no longer up. Removes the variant and all match arms across the chain, solvers, liquidity-sources, and price-estimation crates. Extracted from #4422 for independent review.
Original comment: #4422 (comment)