Skip to content

Remove deprecated Goerli chain#4425

Merged
AryanGodara merged 2 commits into
mainfrom
chore/remove-goerli
May 20, 2026
Merged

Remove deprecated Goerli chain#4425
AryanGodara merged 2 commits into
mainfrom
chore/remove-goerli

Conversation

@AryanGodara
Copy link
Copy Markdown
Member

Goerli is no longer up. Removes the variant and all match arms across the chain, solvers, liquidity-sources, and price-estimation crates. Extracted from #4422 for independent review.

Original comment: #4422 (comment)

@AryanGodara AryanGodara self-assigned this May 20, 2026
@AryanGodara AryanGodara marked this pull request as ready for review May 20, 2026 10:34
@AryanGodara AryanGodara requested a review from a team as a code owner May 20, 2026 10:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all references to the Goerli testnet across the codebase, including its definition in the Chain and ChainId enums, associated liquidity sources, price estimation logic, and relevant unit tests. I have no feedback to provide as the changes are consistent and correctly implement the removal of the deprecated network.

Copy link
Copy Markdown
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile.cowswap still contains some Goerli mentions.

@AryanGodara AryanGodara requested a review from squadgazzz May 20, 2026 11:05
@AryanGodara AryanGodara added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 052c7d1 May 20, 2026
20 checks passed
@AryanGodara AryanGodara deleted the chore/remove-goerli branch May 20, 2026 12:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants