Skip to content

[feat][backend]fix NewDataset#274

Merged
zero3233-bd merged 1 commit intomainfrom
feat/auto_task_opt
Oct 31, 2025
Merged

[feat][backend]fix NewDataset#274
zero3233-bd merged 1 commit intomainfrom
feat/auto_task_opt

Conversation

@zero3233-bd
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   68.01%   68.02%           
=======================================
  Files         568      568           
  Lines       50478    50480    +2     
=======================================
+ Hits        34335    34341    +6     
+ Misses      13473    13471    -2     
+ Partials     2670     2668    -2     
Flag Coverage Δ
unittests 68.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/task/service/taskexe/processor/auto_evaluate.go 82.31% <100.00%> (+0.05%) ⬆️
...dules/observability/domain/trace/entity/dataset.go 85.36% <100.00%> (+0.11%) ⬆️
...ility/domain/trace/service/trace_export_service.go 72.30% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5774a73...66d1cd8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes focusing on dataset construction and call sites. The re-introduction of EvaluationBizCategory and adjustments to NewDataset usage compile cleanly and pass tests. No correctness or concurrency risks found in the modified lines. Approving.

@zero3233-bd zero3233-bd merged commit 8b4ff9d into main Oct 31, 2025
17 of 19 checks passed
@zero3233-bd zero3233-bd deleted the feat/auto_task_opt branch October 31, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants