Skip to content

[feat][backend] trace oapi support original tag#303

Merged
cuichen01 merged 8 commits intomainfrom
ft_cc_trace_oapi_update
Nov 19, 2025
Merged

[feat][backend] trace oapi support original tag#303
cuichen01 merged 8 commits intomainfrom
ft_cc_trace_oapi_update

Conversation

@cuichen01
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review comments added focusing on original tag propagation and map aliasing risks.

Comment thread backend/modules/observability/application/convertor/trace/span.go
Comment thread backend/modules/observability/application/openapi.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   68.44%   68.52%   +0.08%     
==========================================
  Files         569      569              
  Lines       51765    51775      +10     
==========================================
+ Hits        35432    35481      +49     
+ Misses      13582    13555      -27     
+ Partials     2751     2739      -12     
Flag Coverage Δ
unittests 68.52% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../observability/application/convertor/trace/span.go 82.03% <100.00%> (+25.98%) ⬆️
...ckend/modules/observability/application/openapi.go 74.68% <100.00%> (ø)
backend/modules/observability/application/trace.go 69.42% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145e91f...5e2dbf6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cuichen01 and others added 3 commits November 19, 2025 16:19
(LogID: 202511191610160100910941979492F31)

Co-Authored-By: Coda <coda@bytedance.com>
@cuichen01 cuichen01 merged commit c0f3de1 into main Nov 19, 2025
18 checks passed
@cuichen01 cuichen01 deleted the ft_cc_trace_oapi_update branch November 19, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants