Skip to content

[fix][evaluation]expt download#325

Merged
tpfz merged 7 commits intomainfrom
feat/wzq/fix-download
Dec 4, 2025
Merged

[fix][evaluation]expt download#325
tpfz merged 7 commits intomainfrom
feat/wzq/fix-download

Conversation

@tpfz
Copy link
Copy Markdown
Collaborator

@tpfz tpfz commented Dec 3, 2025

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

lsy357
lsy357 previously approved these changes Dec 3, 2025
Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted inline review comments addressing secure logging of signed URLs.

Comment thread backend/modules/evaluation/domain/service/url_processor_impl.go
Comment thread backend/modules/evaluation/domain/service/expt_export_impl.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ules/evaluation/domain/service/expt_export_impl.go 33.33% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   69.46%   69.49%   +0.02%     
==========================================
  Files         588      589       +1     
  Lines       55147    55156       +9     
==========================================
+ Hits        38310    38328      +18     
+ Misses      13938    13930       -8     
+ Partials     2899     2898       -1     
Flag Coverage Δ
unittests 69.49% <89.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...application/convertor/target/eval_target_record.go 86.95% <100.00%> (ø)
...es/evaluation/domain/service/url_processor_impl.go 100.00% <100.00%> (ø)
...ules/evaluation/domain/service/expt_export_impl.go 77.72% <33.33%> (+1.35%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebf3d3...bcd74d6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpfz tpfz merged commit 8889abe into main Dec 4, 2025
17 checks passed
@tpfz tpfz deleted the feat/wzq/fix-download branch December 4, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants