Skip to content

[fix] [backend] timestamp bug in automation#336

Merged
taoyifan89 merged 13 commits intomainfrom
fix/task_timestamp
Dec 10, 2025
Merged

[fix] [backend] timestamp bug in automation#336
taoyifan89 merged 13 commits intomainfrom
fix/task_timestamp

Conversation

@lsy357
Copy link
Copy Markdown
Collaborator

@lsy357 lsy357 commented Dec 8, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
Change-Id: I923bfa772de801964c637a9741216dcf383eb1ef
zh(optional):

(Optional) Which issue(s) this PR fixes:

Commit Details

  • SHA: 6974cc8f1f6a8c1916308ac16ca1a6844aedb661
  • Author: taoyifan89 taoyifan@bytedance.com
  • Date: 2025-12-05 09:29:26

This PR was automatically created from commit 6974cc8f1f6a8c1916308ac16ca1a6844aedb661.

Change-Id: I923bfa772de801964c637a9741216dcf383eb1ef
@mocayo mocayo changed the title Fix timestamp bug in automation. [fix] [backend] timestamp bug in automation Dec 8, 2025
Change-Id: Ice4ffadf1819f4e46ad287b77a27d92f34f406aa
Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Fix unit mismatch in annotation queries and align method naming; reduce logging verbosity.

  • Must-Fix: Use milliseconds for ListAnnotationsParam.StartAt/EndAt (convert microseconds via /1000).
  • Should-Fix: Rename GetPlatfromType to GetPlatformType and update call sites.
  • Should-Fix: Avoid logging entire task object; log concise identifiers instead.

Comment thread backend/modules/observability/domain/task/service/task_callback.go Outdated
Comment thread backend/modules/observability/domain/task/entity/event.go Outdated
Comment thread backend/modules/observability/domain/task/service/task_callback.go Outdated
Comment thread backend/modules/observability/domain/task/service/task_callback.go
Comment thread backend/modules/observability/domain/task/service/task_callback.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 89.90826% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...observability/domain/task/service/task_callback.go 83.33% 2 Missing and 2 partials ⚠️
...domain/task/service/taskexe/tracehub/subscriber.go 0.00% 2 Missing and 1 partial ⚠️
.../modules/observability/domain/task/entity/event.go 96.82% 0 Missing and 2 partials ⚠️
...d/modules/observability/domain/task/entity/task.go 80.00% 1 Missing ⚠️
backend/modules/observability/infra/repo/trace.go 66.66% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   69.88%   70.19%   +0.31%     
==========================================
  Files         588      588              
  Lines       54452    54544      +92     
==========================================
+ Hits        38052    38288     +236     
+ Misses      13525    13384     -141     
+ Partials     2875     2872       -3     
Flag Coverage Δ
unittests 70.19% <89.90%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/task/service/taskexe/processor/auto_evaluate.go 86.71% <100.00%> (+0.13%) ⬆️
...y/domain/task/service/taskexe/tracehub/backfill.go 65.94% <ø> (-0.13%) ⬇️
...ervability/domain/trace/entity/loop_span/filter.go 70.80% <ø> (ø)
...bservability/domain/trace/entity/loop_span/span.go 75.92% <100.00%> (+0.18%) ⬆️
...d/modules/observability/domain/task/entity/task.go 48.07% <80.00%> (+1.07%) ⬆️
backend/modules/observability/infra/repo/trace.go 84.03% <66.66%> (+1.96%) ⬆️
.../modules/observability/domain/task/entity/event.go 78.57% <96.82%> (+20.43%) ⬆️
...domain/task/service/taskexe/tracehub/subscriber.go 68.42% <0.00%> (-1.85%) ⬇️
...observability/domain/task/service/task_callback.go 85.79% <83.33%> (+0.48%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5177532...f5fa442. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: I643c6ba415f8a1e7b87a7d16753286dbbc18f2aa
Change-Id: I0096433d2eef5fe42980bef3dbea0a1a9200f01b
Change-Id: Iac4b6ebaf95d1f3d8a1e0f08196dba70117d10bc
Change-Id: Icd15ba267409164110f65bb816583a14cc30d9a9
Change-Id: Iec1123ef13907c9714002ce727daaa9d5b404739
Change-Id: I00ca3d8bbc46087ab30b512504007fb0562238ef
Change-Id: I83b8b58c69f322216880531fd20999056ff305ae
Change-Id: I3c4b7d333edb911c01f2d173618c5bd85b38f86e
Change-Id: Ibc0668df64e876a229dc1dd706ed2072d42de0ce
Change-Id: I735ee689be8e33bf3a284f2d5ab550f48665c700
Change-Id: I5088fb5e46a75f2ad273bf8f8bf612482e08cc07
@taoyifan89 taoyifan89 merged commit 87a5550 into main Dec 10, 2025
17 checks passed
@taoyifan89 taoyifan89 deleted the fix/task_timestamp branch December 10, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants