Skip to content

[feat][evaluation]fix evaluation bugs#338

Merged
tpfz merged 10 commits intomainfrom
feat/wzq/bugfix_1209
Dec 10, 2025
Merged

[feat][evaluation]fix evaluation bugs#338
tpfz merged 10 commits intomainfrom
feat/wzq/bugfix_1209

Conversation

@tpfz
Copy link
Copy Markdown
Collaborator

@tpfz tpfz commented Dec 9, 2025

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting review comments. Summary: 1) handle BatchGet error logging; 2) handle Ext JSON unmarshal errors; 3) align k8s Helm SQL schema with Docker Compose by adding ext column.

Comment thread backend/modules/evaluation/domain/service/expt_run_item_impl.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   69.88%   70.10%   +0.22%     
==========================================
  Files         588      588              
  Lines       54452    54468      +16     
==========================================
+ Hits        38052    38185     +133     
+ Misses      13525    13399     -126     
- Partials     2875     2884       +9     
Flag Coverage Δ
unittests 70.10% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pplication/convertor/evaluator/evaluator_record.go 100.00% <100.00%> (+56.25%) ⬆️
...nd/modules/evaluation/domain/entity/expt_result.go 57.29% <ø> (ø)
...ation/domain/service/expt_manage_execution_impl.go 68.65% <100.00%> (+15.54%) ⬆️
...es/evaluation/domain/service/expt_run_item_impl.go 67.72% <100.00%> (+6.68%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a859aad...217ac43. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpfz tpfz merged commit 2b8ffdb into main Dec 10, 2025
17 checks passed
@tpfz tpfz deleted the feat/wzq/bugfix_1209 branch December 10, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants