Skip to content

[fix]ListPreSpan use GetTraceProcessor#340

Merged
kidkidkid merged 3 commits intomainfrom
fix_list_pre_span
Dec 10, 2025
Merged

[fix]ListPreSpan use GetTraceProcessor#340
kidkidkid merged 3 commits intomainfrom
fix_list_pre_span

Conversation

@JqRrt
Copy link
Copy Markdown
Collaborator

@JqRrt JqRrt commented Dec 9, 2025

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 backend file (excluding ignored paths). No issues identified; change is risk-free.

Comment thread backend/modules/observability/domain/trace/service/trace_service.go
Copy link
Copy Markdown
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

变更无风险

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   69.88%   70.10%   +0.22%     
==========================================
  Files         588      588              
  Lines       54452    54472      +20     
==========================================
+ Hits        38052    38190     +138     
+ Misses      13525    13396     -129     
- Partials     2875     2886      +11     
Flag Coverage Δ
unittests 70.10% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bservability/domain/trace/service/trace_service.go 83.31% <100.00%> (ø)
backend/modules/observability/infra/repo/trace.go 84.00% <100.00%> (+1.92%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a859aad...bcea2bf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid merged commit 5585705 into main Dec 10, 2025
11 checks passed
@kidkidkid kidkidkid deleted the fix_list_pre_span branch December 10, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants