Skip to content

[feat][evaluation] support evaltarget usage#345

Merged
lsy357 merged 14 commits intomainfrom
feat/targetusage
Dec 15, 2025
Merged

[feat][evaluation] support evaltarget usage#345
lsy357 merged 14 commits intomainfrom
feat/targetusage

Conversation

@lsy357
Copy link
Copy Markdown
Collaborator

@lsy357 lsy357 commented Dec 15, 2025

What type of PR is this?

feat

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@lsy357 lsy357 changed the title Feat/targetusage [feat][evaluation] support evaltarget usage Dec 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 79.85075% with 54 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ules/evaluation/domain/service/expt_result_impl.go 66.17% 19 Missing and 4 partials ⚠️
...nfra/repo/experiment/ck/expt_turn_result_filter.go 73.91% 8 Missing and 4 partials ⚠️
...ules/evaluation/domain/service/expt_export_impl.go 73.17% 8 Missing and 3 partials ⚠️
backend/modules/evaluation/domain/entity/target.go 0.00% 6 Missing ⚠️
...modules/evaluation/application/eval_openapi_app.go 77.77% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (79.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   69.63%   69.66%   +0.02%     
==========================================
  Files         608      608              
  Lines       55717    55876     +159     
==========================================
+ Hits        38798    38924     +126     
- Misses      14028    14054      +26     
- Partials     2891     2898       +7     
Flag Coverage Δ
unittests 69.66% <79.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on/application/convertor/experiment/expt_result.go 81.22% <100.00%> (+1.50%) ⬆️
...luation/application/convertor/experiment/filter.go 38.48% <100.00%> (+3.02%) ⬆️
...uation/application/convertor/experiment/openapi.go 79.65% <100.00%> (+0.35%) ⬆️
...application/convertor/target/eval_target_record.go 87.12% <100.00%> (+0.16%) ⬆️
...d/modules/evaluation/application/experiment_app.go 76.67% <100.00%> (+0.02%) ⬆️
backend/modules/evaluation/domain/entity/expt.go 96.77% <100.00%> (+0.10%) ⬆️
...nd/modules/evaluation/domain/entity/expt_result.go 57.73% <100.00%> (+0.44%) ⬆️
.../modules/evaluation/domain/entity/target_record.go 50.00% <ø> (ø)
...ation/domain/service/expt_manage_execution_impl.go 69.10% <100.00%> (+0.44%) ⬆️
...on/domain/service/target_source_loopprompt_impl.go 90.23% <100.00%> (+0.02%) ⬆️
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5f9b2...c78e5c0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dsf86
dsf86 previously approved these changes Dec 15, 2025
HymanShi
HymanShi previously approved these changes Dec 15, 2025
@lsy357 lsy357 dismissed stale reviews from HymanShi and dsf86 via 223a110 December 15, 2025 09:50
dsf86
dsf86 previously approved these changes Dec 15, 2025
@lsy357 lsy357 merged commit a9a7a3f into main Dec 15, 2025
12 of 14 checks passed
@lsy357 lsy357 deleted the feat/targetusage branch December 15, 2025 10:36
Ev4nFeng pushed a commit that referenced this pull request Dec 16, 2025
* fix(evaluation): target usage

* fix(evaluation): expt report evaltargetcolumn

* fix(evaluation): patch code

* fix(evaluation): report column name const

* fix(evaluation): unnecessary idl

* feat(evaluation): expt report evaltargetmtr

* draft

* fix(evaluation): target record load total token

* add ut

* fix(evaluation): ut

* fix(evaluation): ut

* fix(evaluation): golint

* fix(evaluation): export column name

* fix(evaluation): golint

---------

Co-authored-by: tpfz <wangziqi.9425@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants