Skip to content

[feat][backend]: refactor offline metrics#367

Merged
kidkidkid merged 2 commits intomainfrom
feat/refactor_offline_metric
Dec 29, 2025
Merged

[feat][backend]: refactor offline metrics#367
kidkidkid merged 2 commits intomainfrom
feat/refactor_offline_metric

Conversation

@kidkidkid
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 81.60000% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ervability/domain/metric/service/offline_metric.go 86.53% 11 Missing and 3 partials ⚠️
...ackend/modules/observability/application/metric.go 50.00% 3 Missing and 4 partials ⚠️
...ules/observability/domain/metric/service/metric.go 71.42% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   69.48%   69.58%   +0.09%     
==========================================
  Files         616      616              
  Lines       58135    58197      +62     
==========================================
+ Hits        40397    40498     +101     
+ Misses      14775    14719      -56     
- Partials     2963     2980      +17     
Flag Coverage Δ
unittests 69.58% <81.60%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/observability/domain/metric/service/metric.go 60.61% <71.42%> (+1.89%) ⬆️
...ackend/modules/observability/application/metric.go 69.75% <50.00%> (-2.44%) ⬇️
...ervability/domain/metric/service/offline_metric.go 86.84% <86.53%> (+19.53%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c143927...2e74ed0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kidkidkid kidkidkid force-pushed the feat/refactor_offline_metric branch from 6dc95cd to 5b2367b Compare December 29, 2025 06:40
taoyifan89
taoyifan89 previously approved these changes Dec 29, 2025
@kidkidkid kidkidkid force-pushed the feat/refactor_offline_metric branch 2 times, most recently from 7f7e8f1 to ece01be Compare December 29, 2025 08:16
@kidkidkid kidkidkid force-pushed the feat/refactor_offline_metric branch from ece01be to 2e74ed0 Compare December 29, 2025 08:18
@kidkidkid kidkidkid merged commit 86f6aa2 into main Dec 29, 2025
17 of 18 checks passed
@kidkidkid kidkidkid deleted the feat/refactor_offline_metric branch December 29, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants