Skip to content

[feat][evaluation]fix aggr#388

Merged
tpfz merged 11 commits intomainfrom
feat/wzq/fix_aggr
Jan 16, 2026
Merged

[feat][evaluation]fix aggr#388
tpfz merged 11 commits intomainfrom
feat/wzq/fix_aggr

Conversation

@tpfz
Copy link
Copy Markdown
Collaborator

@tpfz tpfz commented Jan 14, 2026

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/modules/evaluation/pkg/utils/trim.go 95.09% 4 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   69.84%   69.93%   +0.08%     
==========================================
  Files         617      618       +1     
  Lines       58459    58621     +162     
==========================================
+ Hits        40832    40997     +165     
+ Misses      14642    14638       -4     
- Partials     2985     2986       +1     
Flag Coverage Δ
unittests 69.93% <96.15%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/modules/evaluation/application/experiment_app.go 78.54% <100.00%> (+0.02%) ⬆️
...nd/modules/evaluation/domain/entity/expt_result.go 54.05% <ø> (ø)
...evaluation/domain/service/expt_result_aggr_impl.go 79.41% <100.00%> (+0.34%) ⬆️
...ules/evaluation/domain/service/expt_result_impl.go 64.55% <100.00%> (+0.38%) ⬆️
backend/modules/evaluation/pkg/utils/trim.go 95.09% <95.09%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622587b...30957d6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpfz tpfz merged commit 1e415de into main Jan 16, 2026
17 of 18 checks passed
@tpfz tpfz deleted the feat/wzq/fix_aggr branch January 16, 2026 03:24
Celoria pushed a commit that referenced this pull request Jan 16, 2026
* fix annotation aggr

* fix 乐观锁

* fix trajectory

---------

Co-authored-by: tpfz <tpfz@bytedance.com>
HearyShen pushed a commit that referenced this pull request Feb 26, 2026
* fix annotation aggr

* fix 乐观锁

* fix trajectory

---------

Co-authored-by: tpfz <tpfz@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants