[feat] [evaluation] generalize evaluator skip rule to intercept rule#522
Merged
xiaowuxiaowu1 merged 3 commits intoMay 14, 2026
Merged
Conversation
Rename ShouldSkip to ShouldIntercept across interfaces, implementations, and tests. Add RunStatus field to EvaluatorOutputData so that intercept rules can control both score and status of evaluator records.
…emantics Align variable names and comments with the intercept semantics instead of the legacy skip terminology.
|
|
…return value Align ShouldIntercept return style with Run method - status is now an independent return value instead of being embedded in the DO struct.
HearyShen
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename ShouldSkip to ShouldIntercept across interfaces, implementations, and tests. Add RunStatus field to EvaluatorOutputData so that intercept rules can control both score and status of evaluator records.
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes