Fix permissions on log directory #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages not served unless `logs` directory is accessible.
Closed
Owner
|
I'm a bit confused here. How do execution permissions solve the issue? |
Contributor
Author
|
I'm not sure. The code doesn't seem to depend on logs successfully being written. |
Owner
|
I'd like to understand what's happening before I merge this. The log folder should not require execution privileges |
Owner
|
I think I understand now. You need execute permissions to traverse the log directory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages not served unless
logsdirectory is accessible.Fixes #8