feat: Added logout url to an instance settings endpoint

[shepilov]

Specially for the flagship app.

To be able to initiate OIDC logout from the client app

[taratatach]

It should probably be added to the response from updateInstance() as well.
In fact, a helper to build this response for both methods would be nice.

[shepilov]

It should probably be added to the response from updateInstance() as well. In fact, a helper to build this response for both methods would be nice.

Why do you need it in the updateInstance response?

[taratatach]

Why do you need it in the updateInstance response?

The method returns an io.cozy.settings.instance object as well.

[shepilov]

Why do you need it in the updateInstance response?

The method returns an io.cozy.settings.instance object as well.

Yes, but it won't be called to have information about the instance, and specifically from the flagship app.
And I hope it's a tmp solution, and we will have a specific configuration endpoint soon, which we've discussed on barcamp

[shepilov]

It should probably be added to the response from updateInstance() as well. In fact, a helper to build this response for both methods would be nice.

fix with the same code in updateInstance, yes, it's cahced for 60 min in the cozy-client, so I didn't find a place were we updating cozy-instance with client but anyway.

You can create a separate issue for the refactoring because it's not so straightforward. We are calling an external service for a legal_notice_url, and errors should be treated more carefully. especially on instance update