Skip to content

Conversation

@lexfrei
Copy link
Contributor

@lexfrei lexfrei commented Jan 15, 2026

Description

Add CI workflow for PR validation and update GoReleaser configuration.

Changes

GoReleaser v2 migration:

  • Upgrade config from version 1 to 2
  • Drop i386 architecture (keep amd64 and arm64 only)
  • Add dist/ to .gitignore

PR workflow:

  • test job: runs go test ./...
  • dco job: verifies all commits have Signed-off-by

Checklist

  • PR title follows Conventional Commits
  • All commits are signed-off (git commit --signoff)
  • Tests pass (go test ./...)

Summary by CodeRabbit

  • Chores
    • Added a pull-request validation workflow that runs tests and enforces Developer Certificate of Origin (DCO) sign-off.
    • Updated release configuration: bumped release schema version and added multi-architecture build targets (amd64, arm64).
    • Expanded ignore rules to exclude generated distribution artifacts (dist/).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Adds a GitHub Actions PR workflow that runs tests and enforces DCO sign-offs; updates GoReleaser config (version bump, adds amd64/arm64 architectures); and expands .gitignore to exclude the dist/ directory.

Changes

Cohort / File(s) Summary
Workflow Configuration
\.github/workflows/pr\.yml
New workflow triggered on pull_request to main with two jobs: test (checks out code, sets up Go, runs go test ./...) and dco (checks out with fetch-depth: 0, iterates commit range from base..head, verifies Signed-off-by: trailers, fails if any commits are unsigned and prints them).
Build & Release Configuration
\.goreleaser\.yaml
Bumps GoReleaser config version from 1 to 2 and adds goarch entries (amd64, arm64) under the first builds item.
Ignore Rules
\.gitignore
Adds dist/ to ignore list to exclude distribution/build artifacts.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through commits with care and cheer,
I checked each sign-off, far and near.
Builds now list amd64 and arm,
dist/ hides softly on the farm,
Tests ran green — a carrot cheer! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main changes: adding PR checks and migrating GoReleaser to v2, which are the primary objectives reflected in all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab41e0a and f9c9089.

📒 Files selected for processing (2)
  • .github/workflows/pr.yml
  • .goreleaser.yaml

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lexfrei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's continuous integration and release processes. It introduces automated checks for pull requests to ensure code quality and proper commit hygiene, while also modernizing the release pipeline by upgrading GoReleaser and streamlining its configuration for more efficient and targeted builds.

Highlights

  • GoReleaser v2 Migration: The GoReleaser configuration has been upgraded from version 1 to version 2. This update includes dropping support for the i386 architecture, now targeting only amd64 and arm64, and disabling the built-in changelog generation feature. Additionally, the dist/ directory has been added to .gitignore to prevent compiled artifacts from being committed.
  • New PR Workflow: A new CI workflow has been introduced for pull request validation. This workflow includes a test job to run go test ./... and a dco job to verify that all commits are signed-off. A new pull request template with a checklist has also been added to guide contributors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pr.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add a CI workflow for PRs and migrate GoReleaser to v2. The GoReleaser migration and associated changes in .gitignore and the new PR template are well-implemented. I've provided a couple of suggestions to enhance the PR template and refine the build matrix in the GoReleaser configuration.

However, there is a critical issue: the PR description states that a CI workflow for PR validation (test and dco jobs) has been added, but the corresponding workflow file (e.g., in .github/workflows/) is missing from the file changes. Please add the missing workflow file to this pull request.

@lexfrei lexfrei requested a review from kvaps January 15, 2026 16:30
@lexfrei
Copy link
Contributor Author

lexfrei commented Jan 15, 2026

Build failures are false positives — the errors in pkg/yamltools/yamltools.go and pkg/engine/helm/engine.go are already fixed in #98.

Once #98 is merged to main, this PR can be rebased and CI will pass.

Safe to merge after #98.

@lexfrei lexfrei self-assigned this Jan 15, 2026
- Upgrade goreleaser config from version 1 to 2
- Remove i386 (386) architecture, keep only amd64 and arm64
- Disable built-in changelog generation
- Add dist/ to .gitignore

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
- Add PR workflow that runs on pull requests to main
- test job: runs go test ./...
- dco job: verifies all commits have Signed-off-by
- Add PR template with checklist

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps merged commit 7936e50 into main Jan 16, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants