-
Notifications
You must be signed in to change notification settings - Fork 21
ci(build): add PR checks and migrate GoReleaser to v2 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a GitHub Actions PR workflow that runs tests and enforces DCO sign-offs; updates GoReleaser config (version bump, adds amd64/arm64 architectures); and expands .gitignore to exclude the Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @lexfrei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's continuous integration and release processes. It introduces automated checks for pull requests to ensure code quality and proper commit hygiene, while also modernizing the release pipeline by upgrading GoReleaser and streamlining its configuration for more efficient and targeted builds. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add a CI workflow for PRs and migrate GoReleaser to v2. The GoReleaser migration and associated changes in .gitignore and the new PR template are well-implemented. I've provided a couple of suggestions to enhance the PR template and refine the build matrix in the GoReleaser configuration.
However, there is a critical issue: the PR description states that a CI workflow for PR validation (test and dco jobs) has been added, but the corresponding workflow file (e.g., in .github/workflows/) is missing from the file changes. Please add the missing workflow file to this pull request.
- Upgrade goreleaser config from version 1 to 2 - Remove i386 (386) architecture, keep only amd64 and arm64 - Disable built-in changelog generation - Add dist/ to .gitignore Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
- Add PR workflow that runs on pull requests to main - test job: runs go test ./... - dco job: verifies all commits have Signed-off-by - Add PR template with checklist Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
kvaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add CI workflow for PR validation and update GoReleaser configuration.
Changes
GoReleaser v2 migration:
dist/to.gitignorePR workflow:
testjob: runsgo test ./...dcojob: verifies all commits haveSigned-off-byChecklist
git commit --signoff)go test ./...)Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.