fix(oss-health): correct April 2026 telemetry snapshot and pause fetch cron#508
fix(oss-health): correct April 2026 telemetry snapshot and pause fetch cron#508
Conversation
…h cron The telemetry-server /api/overview endpoint freezes its current-month snapshot at the first request of the month, so April 2026 has been serving 43 clusters / 164 nodes / 83 tenants since April 1 while live VictoriaMetrics shows 112 / 450 / 444 as of 2026-04-22. Update the cached month values on-site with the live numbers, scale apps linearly by the cluster ratio (112 / 43), and recompute quarter / year averages so the rolled-up periods reflect the correction too. Pause the daily fetch cron until the server-side fix ships (cozystack/cozystack-telemetry-server: current-month snapshots must be regenerated on every request and never persisted). Without the pause, tomorrow's 08:00 UTC run would pull the stale API response and revert this commit. workflow_dispatch is kept for manual refresh. Related server-side fix: cozystack/cozystack-telemetry-server branch fix/current-month-live-and-tenant-label also corrects the total_tenants query (kind="tenant" -> kind="Tenant") which was silently returning 0. Signed-off-by: tym83 <6355522@gmail.com>
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe GitHub Actions workflow disables automatic daily telemetry data fetching by commenting out the cron schedule, while preserving manual trigger capability. Simultaneously, telemetry metrics are updated with refreshed timestamps and revised cluster, node, tenant, and application deployment counts. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the telemetry data in telemetry.json, including timestamps and various usage metrics for clusters, nodes, tenants, and applications. A critical issue was identified: the workflow modification mentioned in the PR description to pause the daily fetch cron is missing from the changes, which would result in these manual updates being overwritten by the next scheduled run.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "updated_at": "2026-04-17T19:38:08Z", | |||
| "updated_at": "2026-04-22T18:11:05Z", | |||
There was a problem hiding this comment.
The pull request description states that the .github/workflows/fetch-telemetry.yml file was modified to comment out the schedule block and pause the daily fetch cron. However, this file is missing from the current pull request. Without this change, the manual corrections in telemetry.json will be overwritten by the next scheduled run of the telemetry fetch workflow. Please include the workflow changes in this PR to ensure the fix persists.
1 participant
Summary
Manually correct the April 2026 telemetry snapshot on
cozystack.io/oss-health/telemetry/with live VictoriaMetrics values (112 clusters / 450 nodes / 444 tenants as of 2026-04-22) and pause the daily fetch cron until the upstream server fix ships.Root cause: the telemetry-server
/api/overviewendpoint freezes the current-month snapshot at the first-of-month request. See cozystack/cozystack-telemetry-server#5 for the server fix. Until that is deployed, everyfetch-telemetry.ymlrun would overwrite this correction with stale 43 / 164 / 83.What
static/oss-health-data/telemetry.json:month(April 2026) → 112 / 450 / 444. Apps scaled linearly by the cluster ratio 112 / 43 ≈ 2.6047.quarterandyearaverages recomputed: March derived from(2 × old_avg − stale_april), new average computed with the corrected April. Apps given the same treatment..github/workflows/fetch-telemetry.yml:schedule:block commented out with a TODO pointing at the upstream fix.workflow_dispatch:kept for manual refresh.Why
Without pausing the cron the next 08:00 UTC run would revert this commit. Keeping
workflow_dispatch:means we can trigger the fetch on-demand once the server fix is live, to verify it returns live data before re-enabling the schedule.Test plan
/oss-health/telemetry/Fetch Telemetry Datawith only manual triggerSummary by CodeRabbit