optimization: cache contents() in __open paths#336
Merged
atoomic merged 1 commit intocpan-authors:mainfrom Mar 28, 2026
Merged
Conversation
Cache the result of $mock_file->contents() before its first use in both __open and _io_file_mock_open. For directories, contents() scans all keys of %files_being_mocked and sorts — calling it twice per open() was redundant work that grows linearly with mock count. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
atoomic
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cache
$mock_file->contents()result before first use in__openand_io_file_mock_open.Why
contents()for directories scans all keys of%files_being_mocked, filters by path prefix, and sorts — an O(n) operation. Both functions called it twice peropen(): once for the existence check and again for the permission check. With many mocked files, this doubled the cost of everyopen()call.How
Store
my $contents = $mock_file->contents()once, then use$contentsin both the ENOENT check and the permission check.Testing
open.t, io_file_compat.t, perms.t, sysopen.t all pass.
Closes #332
🤖 Generated with Claude Code