fix: format_z loses sign for negative sub-hour timezone offsets#140
Draft
Koan-Bot wants to merge 1 commit into
Draft
fix: format_z loses sign for negative sub-hour timezone offsets#140Koan-Bot wants to merge 1 commit into
Koan-Bot wants to merge 1 commit into
Conversation
int($o / 3600) truncates -1800 to 0, so sprintf("%+03d", 0) produces
"+00" instead of "-00". Affects any negative offset under one hour
(e.g. -0030, -0015, -0045).
Fix: extract sign from original offset before taking abs(), then
format with explicit sign character.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
%zformat code produces+0030instead of-0030for negativesub-hour timezone offsets.
Why
int($offset / 3600)truncates-1800to0, andsprintf("%+03d", 0)renders as+00— the negative sign is lost.This affects any negative offset under one hour (e.g.,
-0030,-0015,-0045).How
Extract sign from the original offset before taking
abs(), thenformat with an explicit sign character instead of relying on
sprintf %+.Testing
New
t/format-z-sign.twith 6 tests covering negative sub-hour,positive sub-hour, and zero offsets. Full test suite passes.
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 25 insertions(+), 1 deletion(-)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline