feat: Make bottom margin customizable and change only when necessary#15
Merged
feat: Make bottom margin customizable and change only when necessary#15
Conversation
Because changing the text frame format affects the undo history, and we can't access the undo stack of a QTextDocument, the best solution is to make it customizable, and change the format only when necessary.
|
Best reviewed: commit by commit
Optimal code review plan
|
ouuan
changed the title
ouuan
changed the title
ouuan
requested review from
coder3101 and
neko-para
and removed request for
coder3101
neko-para
approved these changes
May 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because changing the text frame format affects the undo history, and we can't access the undo stack of a QTextDocument, the best solution is to make it customizable, and change the format only when necessary.