FORD Compatibility #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @cphyc any chance you would consider reviewing and implementing this? |
cphyc
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
Hej,
After bashing my head against Regex for a while I have modified so that the linter will treat FORD markers as comments.
Initially I wanted to make a cli argument
--fordto trigger this, and fall back on the currentl rule if not, but this was tricky in the_ruleslist so I just replaced with the assumption that an error where someone has typed!!or!>not intending to be used by FORD is unlikely, and even if they did it will still be treated as a comment.I also added tests - please check that you are satisfied.