[cmath.syn] Consolidate std namespaces #7598
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@AlisdairM Could you please rebase? |
wg21bot
added
the
needs rebase
There is no ordering dependency between the two typedefs in namespace std, the macros that follow, and teh next opening of namespace std, so move the two typedefs to avoid repeatedly opening an closing the namespace. Note that we could have done this without moving the typedefs as macros are not bound by namespaces, but our convention very sensibly avoids confusing readers by keeping macro definitions outside of namespaces.
AlisdairM
force-pushed
the
consolidate_std_cmath
branch
from
dafa5a9 to
1666dd3
Compare
Contributor
Author
|
Rebased and force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no ordering dependency between the two typedefs in namespace std, the macros that follow, and teh next opening of namespace std, so move the two typedefs to avoid repeatedly opening an closing the namespace.
Note that we could have done this without moving
the typedefs as macros are not bound by namespaces, but our convention very sensibly avoids confusing
readers by keeping macro definitions outside of
namespaces.