Submodulize SFML reference #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitignore:
added ./obj and *.dll
Makefile:
Renamed Thumperr's makefile and created my own
src/Main.cpp
Put the whole program in a try block
Pull in latest upstream commits
Sync changes
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Git Submodules I removed the hard-copy of SFML and use a submodule reference instead. This makes the project much simpler to work with in many ways.
When you clone the repo, you have to run
git submodule initif you want to have files in lib/SFML, otherwise it is just an empty folder (which is fine if you don't need it for what you're doing)EDIT: Oops, I didn't realize this PR included @Lowest0ne's other changes. We'll need those scrutinized as well.