Skip to content

fix timestamps and prevent variable shadowing inside constructor #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix timestamps and prevent variable shadowing inside constructor #46

wants to merge 1 commit into from

Conversation

@MiiNiPaa
Copy link
Contributor

@MiiNiPaa MiiNiPaa commented Oct 8, 2013

Although threre is no risk of mistakenly changing wrong variable when passing by reference, fix makes compiler to not issue a warning.

@ghost ghost assigned LB-- Oct 8, 2013
@LB-- LB-- mentioned this pull request Oct 8, 2013
Merged
@LB--
Copy link
Member

LB-- commented Oct 8, 2013

The solution in #47 uses std::put_time, which I believe is the more correct way to do this. If you disagree, feel free to reopen the pull request and discuss it.

@LB-- LB-- closed this Oct 8, 2013
@LB--
Copy link
Member

LB-- commented Oct 8, 2013

GCC 4.8.1 doesn't support std::put_time yet, so I will probably have this code in as a temporary work around for people who can't compile #47

@LB-- LB-- reopened this Oct 8, 2013
@LB-- LB-- closed this Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@LB-- LB--

Labels

enhancement wontfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MiiNiPaa @LB--