Fix #143: SystemLink Cmake module is unnecessary complexity#145
Conversation
…ption instead The SystemLink.cmake module performed complex operations at link-site to mark imported dependency headers as system includes. This is unnecessary since CPM supports a SYSTEM option that passes SYSTEM to add_subdirectory, causing CMake (>= 3.25) to treat all targets from that subdirectory as system includes natively. All CPMAddPackage calls now use SYSTEM YES, the target_link_system_libraries call is replaced with plain target_link_libraries, and SystemLink.cmake is removed entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@leftibot remove CMake test scripts, that will be confusing to end user, and don't include lefticus tools as a system include |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 20.50% 20.50%
=======================================
Files 5 5
Lines 239 239
Branches 108 110 +2
=======================================
Hits 49 49
+ Misses 186 181 -5
- Partials 4 9 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…cus tools Remove check_system_includes.cmake.in and associated test from test/CMakeLists.txt — these would confuse end users. Remove SYSTEM YES from the lefticus/tools CPMAddPackage call so its headers are not treated as system includes. Requested by @lefticus in PR cpp-best-practices#145 review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Addressed review feedback from @lefticus. New commits: |
|
Hi @lefticus — I tried to address the review feedback but couldn't produce a working change. May need human attention. |
|
Hi @lefticus — I tried to address the review feedback but couldn't produce a working change. May need human attention. |
Automated fix by @leftibot.
What changed
Files
Closes #143
Triggered by @lefticus.