This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Add a working Mac CI build #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddalcino
commented
Mar 11, 2020
| catch2/2.11.0 | ||
| docopt.cpp/0.6.2 | ||
| fmt/6.0.0 | ||
| fmt/6.1.2 |
Collaborator
Author
There was a problem hiding this comment.
This looks like a strange thing to change, but the Mac build consistently fails when fmt is set to 6.0.0. It also fails on my Fedora box. Updating fmt to 6.1.2 appears to correct the issue.
See this issue for reference: lefticus/cpp_weekly_game_project#3
ddalcino
force-pushed
the
add-mac-ci-build
branch
2 times, most recently
from
3aec654 to
f7a7e9d
Compare
ddalcino
force-pushed
the
add-mac-ci-build
branch
from
f7a7e9d to
f983437
Compare
Member
|
@ddalcino thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of people hanging out in the issues section that are having trouble getting this project to build properly on a Mac. For this reason, I think that it's really important to get continuous integration going on the Mac side. This will prevent a lot of headaches for Mac users.